Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let Tendermint p2p addresses be specified by hostname as well as by IP for genesis validators #576

Closed
james-chf opened this issue Oct 11, 2022 · 1 comment · Fixed by #1886
Assignees

Comments

@james-chf
Copy link
Contributor

james-chf commented Oct 11, 2022

When calling namadac utils init-genesis-validator, and in the network config/genesis file, validators' net_addresses are specified in the format {ip:port} e.g.

net_address = "1.2.3.4:26656"

It should be possible to also be able to specify this using a hostname instead of an IP e.g. `"example.com:26656" (https://github.com/informalsystems/tendermint-rs/blob/035acabeb4139454fea03c467f14d007feb1294c/config/src/net.rs#L30-L39).

Note that this net_address config value is used internally for some fields which may need an {ip:port}, for those cases we may need to split out this config value (or resolve the hostname via DNS to an IP address, only where appropriate)

@james-chf
Copy link
Contributor Author

james-chf commented Jan 12, 2023

One big advantage to supporting this is that it would be easier to spin up a local chain with multiple Namada nodes using something like Docker Compose, where each Namada node could run on a predictably named host e.g. namada-1:26656, namada-2:26656, ...

@grarco grarco self-assigned this Aug 10, 2023
phy-chain pushed a commit to phy-chain/namada that referenced this issue Mar 1, 2024
phy-chain pushed a commit to phy-chain/namada that referenced this issue Mar 1, 2024
- Replace gas fee buttons with minimum gas fee
- Account for reveal PK transaction when calculating fees
- Add max button to use all available funds in account
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants