Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix the order of addresses in storage keys #1256

Merged
merged 4 commits into from
Apr 13, 2023
Merged

Conversation

tzemanovic
Copy link
Member

closes #1137

based on 0.14.2

@tzemanovic tzemanovic force-pushed the tomas/fix-addr-storage-key-ord branch from ce762d0 to 420ad85 Compare March 28, 2023 08:17
@tzemanovic
Copy link
Member Author

pls update wasm

tzemanovic added a commit that referenced this pull request Mar 28, 2023
@tzemanovic tzemanovic marked this pull request as ready for review March 28, 2023 08:58
@tzemanovic tzemanovic requested a review from brentstone March 28, 2023 08:58
@brentstone brentstone force-pushed the tomas/fix-addr-storage-key-ord branch from b80545a to eeec602 Compare March 29, 2023 15:25
Copy link
Collaborator

@brentstone brentstone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

tzemanovic added a commit that referenced this pull request Apr 11, 2023
* tomas/fix-addr-storage-key-ord:
  changelog: add #1256
  [ci] wasm checksums update
  core/types/address: order addresses by their string (bech32m) format
  tets/core/storage: add a test for order of addresses in storage keys
@tzemanovic tzemanovic mentioned this pull request Apr 11, 2023
@juped juped merged commit 17c97a2 into main Apr 13, 2023
@juped juped deleted the tomas/fix-addr-storage-key-ord branch April 13, 2023 06:07
bengtlofgren pushed a commit that referenced this pull request May 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

storage keys parsed type doesn't preserve order
3 participants