fix PoS slashing order #1246
Merged
fix PoS slashing order #1246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tzemanovic
force-pushed
the
tomas/fix-pos-slashing
branch
from
5fa1daa to
08fb1d2
Compare
|
the failed test is now from the other issue #1247 |
Closed
This was referenced Mar 27, 2023
tzemanovic
added a commit
that referenced
this pull request
Mar 30, 2023
* tomas/fix-pos-slashing: changelog: add #1246 app/ledger/finalize_block: slash after copying of validator sets scripts: add a helper to repeat e2e test
tzemanovic
added a commit
that referenced
this pull request
Apr 12, 2023
* tomas/fix-pos-slashing: changelog: add #1246 app/ledger/finalize_block: slash after copying of validator sets scripts: add a helper to repeat e2e test
Closed
bengtlofgren
pushed a commit
that referenced
this pull request
May 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
based on 0.14.2
fixes #1245
The failure (before the fix) can be reproduced with:
It's a lot easier to trigger with
min_num_of_blocks = 2set ingenesis/e2e-tests-single-node.tomlThe helper script is being added in this PR.