Fix logging for (un)bond querying. #1239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brentstone
force-pushed
the
brent/fix-bonding-query-logging
branch
2 times, most recently
from
4aed665 to
895f3c0
Compare
tzemanovic
reviewed
Mar 21, 2023
tzemanovic
reviewed
Mar 21, 2023
brentstone
force-pushed
the
brent/fix-bonding-query-logging
branch
from
895f3c0 to
7d58ec7
Compare
brentstone
force-pushed
the
brent/fix-bonding-query-logging
branch
2 times, most recently
from
476051c to
372ee4b
Compare
brentstone
force-pushed
the
brent/fix-bonding-query-logging
branch
3 times, most recently
from
04f5c54 to
abd4bd4
Compare
|
pls update wasm |
|
@brentstone The changes look great, thanks for fixing all these! I just added 2 little commits - the first one can be auto-squashed if it looks ok |
brentstone
force-pushed
the
brent/fix-bonding-query-logging
branch
from
9fa1345 to
3cafbcc
Compare
tzemanovic
approved these changes
Mar 30, 2023
tzemanovic
added a commit
that referenced
this pull request
Mar 30, 2023
* brent/fix-bonding-query-logging: changelog: add #1239 [ci] wasm checksums update client/rpc/query_bonds: refactor writelns test for the CLI output Fix CLI output of `submit_unbond` fix unbond query details when only one of source/validator is specified (and tests) submit_unbond: only print out the unbond tx amount and its withdrawable epoch fix `query_and_print_unbonds` query_bonds: don't show bond entries with 0 amount
tzemanovic
added a commit
that referenced
this pull request
Apr 12, 2023
* brent/fix-bonding-query-logging: changelog: add #1239 [ci] wasm checksums update client/rpc/query_bonds: refactor writelns test for the CLI output Fix CLI output of `submit_unbond` fix unbond query details when only one of source/validator is specified (and tests) submit_unbond: only print out the unbond tx amount and its withdrawable epoch fix `query_and_print_unbonds` query_bonds: don't show bond entries with 0 amount
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the CLI output for different client commands related to PoS actions like bonding and unbonding.
Currently based on 0.14.2. Closes #1232, closes #1236, closes #1219.
Main changes so far:
query_bondsunbondtx, only print to the client the amount just unbonded and the epoch from which it can be withdrawn (previously displayed all withdrawable token data)