Replay protection #1017

grarco · 2023-01-12T22:20:08Z

Addresses #1009

Based on #1051 for TempWlStorage

Implements hash-based replay protection

Updates specs
Adds an internal address for replay protection
Adds a native VP to prevent any writing to the hash subspace
Changes WrapperTx commit to be computed on the hash of the unsigned inner tx
Adds mempool_validate checks
Adds process_proposal checks and rejects block on most errors
Updates finalize_block to store the hash of txs
Unit tests

grarco · 2023-01-13T10:18:33Z

pls update wasm

grarco · 2023-01-13T15:17:16Z

apps/src/lib/node/ledger/shell/mod.rs

+                replay_protection::get_tx_hash_key(&wrapper.tx_hash);
+            if self
+                .storage
+                .has_key(&inner_hash_key)


I could actually use StorageRead::has_key here an everywhere else since, for the moment, I'm not interested in the gas used

apps/src/lib/node/ledger/shell/finalize_block.rs

apps/src/lib/node/ledger/shell/process_proposal.rs

core/src/types/transaction/mod.rs

shared/src/ledger/native_vp/replay_protection.rs

grarco · 2023-01-24T11:27:12Z

pls update wasm

grarco · 2023-02-10T21:24:24Z

pls update wasm

tzemanovic

LGTM, good amount of testing!

…nto draft-0.15 evil: wl_storage gains a 'static * namada/grarco/replay-protection-impl: [ci] wasm checksums update Updates fees in replay protection specs Brings back sig check in `finalize_block` Fixes fee error code [ci] wasm checksums update Fixes fee in unit tests Fmt Refactors replay protection logic Removes wal from replay protection specs Removes unnecessary clones Fixes tx unsigned hash Replay protection VP always rejects Fixes typos changelog: add #1017 [ci] wasm checksums update Clippy Fmt Updates `process_proposal` unit tests Fixes `finalize_block` and adds unit test Updates replay protection specs with protocol txs Updates `process_proposal` unit tests Removes tx hash from storage in `finalize_block` Fixes error codes Refactors `process_proposal` Replay protection checks in `process_proposal` Fixes replay protection specs Refactors `unsigned_hash_tx` Unit test `mempool_validate` Wrapper commit hash on unsigned inner tx Adds tx hash check in mempool validate Updates replay protections specs with governance and unsigned inner hash Adds replay protection internal address and vp Updates replay protection specs changelog: add #1051 core: added `TempWlStorage` for ABCI++ prepare/process proposal

* grarco/replay-protection-impl: [ci] wasm checksums update Updates fees in replay protection specs Brings back sig check in `finalize_block` Fixes fee error code [ci] wasm checksums update Fixes fee in unit tests Fmt Refactors replay protection logic Removes wal from replay protection specs Removes unnecessary clones Fixes tx unsigned hash Replay protection VP always rejects Fixes typos changelog: add #1017 [ci] wasm checksums update Clippy Fmt Updates `process_proposal` unit tests Fixes `finalize_block` and adds unit test Updates replay protection specs with protocol txs Updates `process_proposal` unit tests Removes tx hash from storage in `finalize_block` Fixes error codes Refactors `process_proposal` Replay protection checks in `process_proposal` Fixes replay protection specs Refactors `unsigned_hash_tx` Unit test `mempool_validate` Wrapper commit hash on unsigned inner tx Adds tx hash check in mempool validate Updates replay protections specs with governance and unsigned inner hash Adds replay protection internal address and vp Updates replay protection specs

grarco mentioned this pull request Jan 12, 2023

Replay protection #1009

Closed

3 tasks

grarco force-pushed the grarco/replay-protection-impl branch 2 times, most recently from b2a4067 to 3b56dee Compare January 13, 2023 09:50

grarco added a commit that referenced this pull request Jan 13, 2023

changelog: add #1017

967589f

grarco marked this pull request as ready for review January 13, 2023 11:16

grarco requested a review from tzemanovic January 13, 2023 11:16

grarco commented Jan 13, 2023

View reviewed changes

cwgoes added this to the 0.14 milestone Jan 16, 2023