Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

common storage read trait #166

Closed
tzemanovic opened this issue Jul 8, 2022 · 2 comments
Closed

common storage read trait #166

tzemanovic opened this issue Jul 8, 2022 · 2 comments
Assignees
@tzemanovic @brentstone
Labels
ledger refactor / code quality

Comments

@tzemanovic
Copy link
Member

Depends on #110

Add a common trait for client RPC storage read queries, ledger direct storage access (probably needs to include gas metering somehow), VPs posterior storage read (we shouldn't need to re-use code for reading from pre-state, that's typically only ever done by the VP that owns the given storage key) and tx storage read.
This was referenced Jul 8, 2022
Closed
Closed
@tzemanovic tzemanovic self-assigned this Jul 21, 2022
@tzemanovic tzemanovic moved this to Todo in Namada-Old Jul 21, 2022
@tzemanovic tzemanovic moved this from Todo to WIP in Namada-Old Jul 21, 2022
@tzemanovic tzemanovic moved this from WIP to Todo in Namada-Old Jul 21, 2022
@tzemanovic tzemanovic moved this from Todo to WIP in Namada-Old Jul 22, 2022
@tzemanovic tzemanovic mentioned this issue Jul 22, 2022
Closed
@tzemanovic tzemanovic mentioned this issue Aug 11, 2022
Closed
@tzemanovic tzemanovic moved this from WIP to Pending Devnet in Namada-Old Aug 30, 2022
@james-chf james-chf mentioned this issue Sep 5, 2022
Merged
@cwgoes
Copy link
Contributor

cwgoes commented Jan 13, 2023

@tzemanovic what's the status of this?

@tzemanovic
Copy link
Member Author

done in #324 (incorrectly showing closed, but it was merged)

@github-project-automation github-project-automation bot moved this from Pending Devnet to Tested in Devnet in Namada-Old Jan 13, 2023
phy-chain pushed a commit to phy-chain/namada that referenced this issue Mar 1, 2024
@jurevans
bug/161 - Fix for SendToken validation (anoma#166)
cae9418 
* Fixed default token type in TokenSendForm, removed SocketClient

* Remove logs

* Clean up RpcClient

* Additional cleanup

* Fix default transparent token balance

* Cleaned up implementation

* Merge conflict fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tzemanovic tzemanovic

@brentstone brentstone

Labels
ledger refactor / code quality
Projects
No open projects
Namada-Old
Status: Tested in Devnet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

common read storage trait anoma/anoma
common read storage trait anoma/namada
3 participants
@tzemanovic @cwgoes @brentstone