Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

unify native and WASM VP host env interfaces #110

Closed
tzemanovic opened this issue May 10, 2022 · 0 comments · Fixed by #256
Closed

unify native and WASM VP host env interfaces #110

tzemanovic opened this issue May 10, 2022 · 0 comments · Fixed by #256
Assignees
@tzemanovic
Labels
ledger prio:high validity-predicate wasm

Comments

@tzemanovic
Copy link
Member

tzemanovic commented May 10, 2022 •
edited
Loading

We'll be adding a Ctx arg to the wasm execution on which we can implement the same trait as for the native VP - then any library code can build on top of the trait for re-usability. (This is better than the alternative, in which we would keep the same interface in WASM and somehow "hack" native VP to use implicit Ctx)

Although not strictly necessary, we should also apply the same change to transaction host env to keep them consistent.
@tzemanovic tzemanovic self-assigned this May 10, 2022
@tzemanovic tzemanovic mentioned this issue May 10, 2022
Closed
@tzemanovic tzemanovic transferred this issue from anoma/anoma Jul 7, 2022
This was referenced Jul 8, 2022
Closed
Closed
@tzemanovic tzemanovic moved this from WIP to Queue in Namada-Old Jul 26, 2022
@tzemanovic tzemanovic mentioned this issue Aug 2, 2022
Merged
Repository owner moved this from Pending Devnet to Tested in Devnet in Namada-Old Oct 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tzemanovic tzemanovic

Labels
ledger prio:high validity-predicate wasm
Projects
No open projects
Namada-Old
Status: Tested in Devnet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

unify native and wasm VP anoma/namada
unify native and wasm vp anoma/anoma
1 participant
@tzemanovic