-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New fixity/iterator syntax #2332
Conversation
0fd5b38
to
7ddaef2
Compare
The syntactical asymmetry between |
ab34ae5
to
b6f8148
Compare
This PR contains large deltas with formatting changes putting newlines everywhere. Is this a result of a different version/configuration of ormolu or was this intentional? Personally, I think inserting these newlines makes things less readable. But even if we decide to change the coding style to insert newlines in these places, we should do it in a separate PR. |
3200c74
to
175cc60
Compare
This reverts commit 175cc60.
60ef06b
to
ad37c72
Compare
This pr implements the syntax changes described in #2330. It drops support for the old yaml-based syntax.
Some valid examples:
Future work
This pr creates an asymmetry between iterators and operators definitions. Iterators definition do not require a constructor. We could add it to make it homogeneous, but it looks a bit redundant:
We could consider merging iterator and fixity declarations with this alternative syntax.
where
XXX
is a common keyword. Suggestion by @lukaszcz XXX = declare