Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixity yaml not visible enough in the html source using a dark theme #2329

Closed
janmasrovira opened this issue Aug 30, 2023 · 0 comments · Fixed by #2332
Closed

Fixity yaml not visible enough in the html source using a dark theme #2329

janmasrovira opened this issue Aug 30, 2023 · 0 comments · Fixed by #2332

Comments

@janmasrovira
Copy link
Collaborator

image

@janmasrovira janmasrovira added this to the 0.4.4 milestone Aug 30, 2023
@janmasrovira janmasrovira self-assigned this Aug 30, 2023
@jonaprieto jonaprieto modified the milestones: 0.4.4, 0.5 Sep 7, 2023
jonaprieto pushed a commit that referenced this issue Sep 14, 2023
- Closes #2330
- Closes #2329 

This pr implements the syntax changes described in #2330. It drops
support for the old yaml-based syntax.
Some valid examples:
```
syntax iterator for {init := 1; range := 1};

syntax fixity cons := binary {assoc := right};
syntax fixity cmp := binary;
syntax fixity cmp := binary {}; -- debatable whether we want to accept empty {} or not. I think we should
```
# Future work
This pr creates an asymmetry between iterators and operators
definitions. Iterators definition do not require a constructor. We could
add it to make it homogeneous, but it looks a bit redundant:
```
syntax iterator for := mkIterator {init := 1; range := 1};
```

We could consider merging iterator and fixity declarations with this
alternative syntax.
```
syntax XXX for := iterator {init := 1; range := 1};

syntax XXX cons := binary {assoc := right};
```
where `XXX` is a common keyword. Suggestion by @lukaszcz XXX = declare

---------

Co-authored-by: Łukasz Czajka <[email protected]>
Co-authored-by: Lukasz Czajka <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants