Fixes behaviour of default stdlib when internal-build-flag is set #2283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonaprieto
approved these changes
Aug 9, 2023
The entrypoint is required to determine the build directory, which could be set using `--internal-build-dir` on the CLI.
jonaprieto
force-pushed
the
bug-internal-build-dir-compile
branch
from
d3997b1 to
8f3e134
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The mechanism for using
--internal-build-flagto set the build directory for the default stdlib location already existed, it was just unused (Nothing always passed in, instead of the entry point):juvix/src/Juvix/Compiler/Concrete/Translation/FromParsed/Analysis/PathResolver.hs
Line 128 in 11ebc4a
This PR fixes that issue, adds some smoke tests to check the behaviour of the stdlib dependency.
The issue with what to do with relative stdlib dependency paths when
--internal-build-flagis set remains open: #2274