-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
juvix init
generated juvix.yaml
is incompatible with the internal-build-dir
#2274
Comments
This was referenced Aug 4, 2023
paulcadman
added a commit
that referenced
this issue
Aug 9, 2023
) The mechanism for using `--internal-build-flag` to set the build directory for the default stdlib location already existed, it was just unused (Nothing always passed in, instead of the entry point): https://github.com/anoma/juvix/blob/11ebc4acde4d1c7e70568b35326074e5ee671a77/src/Juvix/Compiler/Concrete/Translation/FromParsed/Analysis/PathResolver.hs#L128 This PR fixes that issue, adds some smoke tests to check the behaviour of the stdlib dependency. * Closes #2273 The issue with what to do with relative stdlib dependency paths when `--internal-build-flag` is set remains open: #2274
Discussed with the team. We should use an external dependency for the standard library:
We should publish releases of the standard library before doing this: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
A juvix project created using
juvix init
comes with a pre-populated dependencies field that points to the stdlib dependency in the default build directory.juvix-build
:juvix.yaml
However we allow users of
juvix compile
to override the build directory using the--internal-build-dir
flag. This currently works because (see #2273) the default stdlib is always copied to.juvix-build/stdlib
, the--internal-build-dir
.To fix this we could implement:
and then have some way of referencing the global project dir in a dependency (perhaps with a magic
#GLOBAL_PROJECT
variable?, though this is ugly, but the global project location is dynamic, it depends onXDG_CONFIG_HOME
).The text was updated successfully, but these errors were encountered: