extend example and add some comments #21
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First of all thanks a ton for creating
archi@anmonteiro!I've extended the example and added some comments. I didn't find it entirely straight forward to use so hopefully this can save someone else a few minutes!
I hope it is acceptable that I pulled in a few more modules into the example to make it more "complete".
I removed the Database type as I was struggling to appease the compiler. In my use outside of this example where I pass the pool on to functions outside of the
startfunction the compiler wouldn't accept it. I'm sure this is doable and I'm lacking knowledge and experience with OCaml so would appreciate some feedback on the PR!