Replace use of window.postMessage in card info #3646
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sorry for bringing this up again, looked through #3572 and the deck options page and came across existing uses of
globalThis.ankiUsing it seems more reliable thanit doesn't need the page to be rendered properly for it to navigate (thewindow.postMessage(from #3621), in thatonmessagelistener is currently added via a component, andcardStatscan still throw when the card doesn't exist) and falls back towindow.locationifgotowere to failAlso added the proposed placeholder format change that was missed out from #3631
EDIT: poor choice of words, postMessage isn't intrisically less reliable than a global fn