NF: explaining the bridge between languages #3572
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Arthur-Milchior
force-pushed
the
doc_bridge
branch
from
a19c20e to
975e317
Compare
|
The technical details appear to be correct. This reads like some rough notes though, and needs some polishing before it's ready for inclusion (things like "as far as I understand" don't really belong in a document that is telling people what to do!) |
It was, honestly, quite confusing. And if I got it wrong, I guess this code review will be the time for me to learn what was wrong.
Arthur-Milchior
force-pushed
the
doc_bridge
branch
from
975e317 to
e5042b3
Compare
|
Appart from the sentence you quoted, is there anything you believe needs more polishing? I would have hoped everything is understandable. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was, honestly, quite confusing. And if I got it wrong, I guess this code review will be the time for me to learn what was wrong.