Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(syntaxes): add back block syntaxes to injection for entire TS file #2063

Merged
merged 1 commit into from
Jul 11, 2024

Conversation

atscott
Copy link
Collaborator

@atscott atscott commented Jul 10, 2024

We rely on the injectionSelector to prevent matching our grammars in contexts which they should not apply. The injectionSelector only applies when the grammar is injected to the file via injectTo. Otherwise, the grammer is applied directly when it is included in the patterns array of another match.

fixes #2062

@atscott atscott added the target: patch This PR is targeted for the next patch release label Jul 10, 2024
@atscott atscott requested a review from dylhunn July 10, 2024 14:32
We rely on the `injectionSelector` to prevent matching our grammars in
contexts which they should not apply. The `injectionSelector` only applies
when the grammar is injected to the file via `injectTo`. Otherwise, the
grammer is applied directly when it is included in the `patterns` array
of another match.

fixes angular#2062
@atscott atscott added action: merge Ready to merge target: minor This PR is targeted for the next minor release and removed target: patch This PR is targeted for the next patch release labels Jul 11, 2024
@atscott atscott merged commit a18c617 into angular:main Jul 11, 2024
5 checks passed
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Aug 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge Ready to merge target: minor This PR is targeted for the next minor release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Control flow syntax highlight not coloring nested if statement
2 participants