Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Control flow syntax highlight not coloring nested if statement #2062

Closed
jpike88 opened this issue Jul 10, 2024 · 3 comments · Fixed by #2063
Closed

Control flow syntax highlight not coloring nested if statement #2062

jpike88 opened this issue Jul 10, 2024 · 3 comments · Fixed by #2063
Labels

Comments

@jpike88
Copy link

jpike88 commented Jul 10, 2024

@if (form) {
			<mat-card style="min-width: 260px;">
				<mat-card-content>
					<fields [form]="form"></fields>
					<button>
						@if (form.submitted) {
							<mat-progress-spinner
								[mode]="'indeterminate'"
								[diameter]="16"
								style="display: inline-block; margin-right: 12px;"
							>
							</mat-progress-spinner>
						}
					</button>
				</mat-card-content>
			</mat-card>
		}

in the above example, that inner if statement is not colourized, it's just grey like below:
Screenshot 2024-07-10 at 8 28 54 AM

@jpike88 jpike88 added the bug label Jul 10, 2024
atscott added a commit to atscott/vscode-ng-language-service that referenced this issue Jul 10, 2024
We rely on the `injectionSelector` to prevent matching our grammars in
contexts which they should not apply. The `injectionSelector` only applies
when the grammar is injected to the file via `injectTo`. Otherwise, the
grammer is applied directly when it is included in the `patterns` array
of another match.

fixes angular#2062
atscott added a commit to atscott/vscode-ng-language-service that referenced this issue Jul 10, 2024
We rely on the `injectionSelector` to prevent matching our grammars in
contexts which they should not apply. The `injectionSelector` only applies
when the grammar is injected to the file via `injectTo`. Otherwise, the
grammer is applied directly when it is included in the `patterns` array
of another match.

fixes angular#2062
@eneajaho
Copy link

I was just going to open this issue 😅

@Taras-R
Copy link

Taras-R commented Jul 11, 2024

I was just going to open this issue 😅

Same here. Worked in v. 18.0.0, crashed in v. 18.1.0. I guess they will fix it soon.

atscott added a commit to atscott/vscode-ng-language-service that referenced this issue Jul 11, 2024
We rely on the `injectionSelector` to prevent matching our grammars in
contexts which they should not apply. The `injectionSelector` only applies
when the grammar is injected to the file via `injectTo`. Otherwise, the
grammer is applied directly when it is included in the `patterns` array
of another match.

fixes angular#2062
atscott added a commit that referenced this issue Jul 11, 2024
We rely on the `injectionSelector` to prevent matching our grammars in
contexts which they should not apply. The `injectionSelector` only applies
when the grammar is injected to the file via `injectTo`. Otherwise, the
grammer is applied directly when it is included in the `patterns` array
of another match.

fixes #2062
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Aug 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
3 participants