This repository has been archived by the owner on Jul 29, 2024. It is now read-only.
chore(dependencies): update selenium-webdriver to 2.47.1 #2559
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Along with it, update `jasminewd2` to avoid situations where the control flow gets locked up and hangs. Potential Breaking Change: This is passing all existing Protractor tests, but there is a possibility that the changes to the control flow will cause some test flows to hang. If this causes issues, please revisit your use of functions affecting the control flow, such as `flow.execute`.
|
+1 |
|
I'm seeing a consistent issue with the polling spec, which only occurs on Travis. Cannot yet reproduce locally or running from my machine to sauce. EDIT: fixed now - issue was due to differences in behavior when |
Previously, the order of frames and tasks on the control flow was different depending on `browser.ignoreSynchronization`. This fixes the inconsistency by creating an empty task when ignoreSynchronization is true. Practically, this fixes the polling spec failing after the update to [email protected].
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Along with it, update
jasminewd2to avoid situations where thecontrol flow gets locked up and hangs.
Potential Breaking Change:
This is passing all existing Protractor tests, but there is a
possibility that the changes to the control flow will cause some
test flows to hang. If this causes issues, please revisit your
use of functions affecting the control flow, such as
flow.execute.