Skip to content
This repository has been archived by the owner on Jul 29, 2024. It is now read-only.

Update to WebDriver 2.47.1 #2245

Closed
juliemr opened this issue Jun 13, 2015 · 8 comments
Closed

Update to WebDriver 2.47.1 #2245

juliemr opened this issue Jun 13, 2015 · 8 comments
Assignees
Milestone

Comments

@juliemr
Copy link
Member

juliemr commented Jun 13, 2015

This will fix several issues, but is currently blocked because selenium-webdriver node module @ 2.46.0 is causing issues with ElementArrayFinder.each, probably due to control flow changes.

@elifa
Copy link

elifa commented Jun 15, 2015

I would appreciate if you could add the proxy support to Protractor that comes with WebDriver 2.46 as well.
I suggest adding this row to the driverProvider.js file:

DriverProvider.prototype.getNewDriver = function() {
    // ...
    usingWebDriverProxy(this.config_.seleniumProxy).
    // ...
}

@juliemr
Copy link
Member Author

juliemr commented Jun 17, 2015

See also #2263

@hankduan
Copy link
Contributor

Here's a test which hangs with webdriver 46, but not 45.

var webdriver = require('selenium-webdriver');
var driver = new webdriver.Builder().
  usingServer('http://localhost:4444/wd/hub').
  withCapabilities(webdriver.Capabilities.chrome()).
  build();
var flow = webdriver.promise.controlFlow();

driver.get('http://www.w3schools.com/html/html_lists.asp');

var printTexts = function(webElems) {
  var attrVals = webElems.then(function(arr) {
    var results = arr.map(function(webElem) {
      return webElem.getText();
    });
    return webdriver.promise.all(results);
  });

  flow.execute(function() {
    return attrVals.then(function(res) {
      console.log(res[0]);
    });
  });

  return true;
};

driver.findElements(webdriver.By.css('.example_result li')).then(function(arr) {
  var result = arr.map(function(webElem) {
    var webElemsPromise = webdriver.promise.fulfilled(webElem).then(function(webElem) {
      return [webElem];
    });
    return webdriver.promise.fullyResolved(printTexts(webElemsPromise));
  });
  return webdriver.promise.all(result);
})

driver.quit();

@hankduan
Copy link
Contributor

fyi, this is pending SeleniumHQ/selenium#796

@sjelin sjelin modified the milestones: 2.3, 2.2 Aug 24, 2015
@juliemr juliemr changed the title Update to WebDriver 2.46.0 Update to WebDriver 2.47.1 Sep 25, 2015
@juliemr
Copy link
Member Author

juliemr commented Sep 25, 2015

NOTE - the pending issue is still pending, but with WebDriverJS 2.47 out and other issues beginning to crop up because of the stale version of WebDriverJS (such as install warnings with node.js 4.1 and errors with new browsers when using directConnect) we are going to go ahead and do the upgrade anyway. We will attempt to outline potential new issues clearly in the breaking changes section of the release notes. Stay tuned!

@juliemr juliemr modified the milestones: 2.4, 2.3 Sep 28, 2015
juliemr added a commit to juliemr/jasminewd that referenced this issue Sep 29, 2015
Update selenium-webdriver to 2.47.0 from 2.45.1.
This update introduces a convoluted situation where some tests in
Proractor's suite would hang - see angular/protractor#2245

This change includes a fix for those issues which removes the explicit
`flow.execute` wrapper around `expect` calls. This appears not to introduce
any issues to existing tests.
@juliemr
Copy link
Member Author

juliemr commented Sep 29, 2015

Update:

I've release a new version of jasminewd2, 0.0.6 which appears to solve most of the issues.

There is one lingering failure in our test suite, which is that elementExplorer no longer works. The server starts, but is shut down immediately. I've confirmed that this is due to the selenium-webdriver version update.

@juliemr
Copy link
Member Author

juliemr commented Sep 29, 2015

See #2559

@juliemr
Copy link
Member Author

juliemr commented Sep 30, 2015

Done with #2559.

@juliemr juliemr closed this as completed Sep 30, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants