Skip to content
This repository has been archived by the owner on Dec 18, 2024. It is now read-only.

build: update to Angular and CLI v12 next.7 and Components v12 next.5 #939

Merged
merged 1 commit into from
Apr 8, 2021

Conversation

Splaktar
Copy link
Member

@Splaktar Splaktar commented Apr 7, 2021

  • fix typing change in ActivatedRoute.fragment
  • fix breaking change to no longer allow the styles bundleName to include a path in the ng build config

@Splaktar
Copy link
Member Author

Splaktar commented Apr 7, 2021

It looks like these test typing errors with components-examples may be related to needing PR angular/components#22390 to land with Angular 12.0.0-next.7 support prior to our docs site moving to that version.

@Splaktar Splaktar requested a review from crisbeto April 7, 2021 04:12
Copy link
Contributor

@wagnermaciel wagnermaciel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@wagnermaciel
Copy link
Contributor

@Splaktar You have a CircleCI failure here but otherwise LGTM

@Splaktar Splaktar removed the request for review from andrewseguin April 7, 2021 15:25
@Splaktar
Copy link
Member Author

Splaktar commented Apr 7, 2021

I'll update now that PR angular/components#22390 is merged and CI should be good to go.

@Splaktar Splaktar requested a review from annieyw April 8, 2021 00:23
- fix typing change in `ActivatedRoute.fragment`
- fix [breaking change](angular/angular-cli#20361)
  to no longer allow the styles `bundleName` to include a path in the ng build config
@Splaktar Splaktar force-pushed the update-dependencies branch from a0f4829 to fb4a322 Compare April 8, 2021 00:25
@Splaktar Splaktar merged commit 8583f02 into angular:master Apr 8, 2021
@Splaktar Splaktar deleted the update-dependencies branch April 8, 2021 00:43
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes dependencies Pull requests that update a dependency file P2: required pr: lgtm
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants