build: bump Angular dependencies and drop benchpress #22390
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
google-cla
bot
added
the
cla: yes
crisbeto
force-pushed
the
benchpress-remove
branch
3 times, most recently
from
a5050b0 to
b543b49
Compare
crisbeto
added
merge safe
P3
crisbeto
requested review from
andrewseguin,
jelbourn,
mmalerba and
a team
as code owners
josephperrott
added
the
blocked
josephperrott
requested changes
Apr 2, 2021
There was a problem hiding this comment.
An issue with validating commits was found for when multiple level scopes as used and will be fixed with: angular/angular#41430 (review)
The dev-infra-private-builds version needs to include this change.
crisbeto
force-pushed
the
benchpress-remove
branch
from
b543b49 to
44f82b0
Compare
crisbeto
removed
the
blocked
|
@crisbeto needs rebase |
* Updates the `@angular` dependencies to the latest versions. * Removes the depenency on `@angular/benchpress` since we weren't using it and it was causing some issues in the snapshot builds.
crisbeto
force-pushed
the
benchpress-remove
branch
from
44f82b0 to
0bd5cb9
Compare
|
Rebased. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@angulardependencies to the latest versions and resolves the build errors.@angular/benchpresssince we weren't using it and it was causing some issues in the snapshot builds.