This repository has been archived by the owner on Apr 9, 2022. It is now read-only.
feat(@schematics/angular): enable 'no-template-call-expression' rule #746
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I just realized that the Update: This was fixed in mgechev/codelyzer#582. I will update this PR with the correct version of |
|
Sorry @kevinphelps - this got lost when we moved back to the angular/angular-cli repo. If you still think this pull request is relevant, could you please re-base on that repo and open a new PR there? Thanks and sorry for the extra churn. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At ng-conf, there was a talk on avoiding binding to function call expression in template to improve change detection performance. Several months ago, I contributed a rule to
codelyzerthat will flag any binding to call expression in template (mgechev/codelyzer#478). This PR enables that rule in thetslint.jsonschematic for Angular projects.