build: use nvmrc version to set node version in WORKSPACE #259
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devversion
approved these changes
Oct 11, 2021
Use the nvmrc version to set the version of node used in WORKSPACE to more centrally manage the version of node being used.
josephperrott
force-pushed
the
use-nvmrc
branch
from
f7e2f7c to
f54c447
Compare
|
This PR was merged into the repository by commit 4fee007. |
devversion
added a commit
to devversion/dev-infra
that referenced
this pull request
Oct 21, 2021
…gular#259)" This reverts commit 4fee007. Commit is reverted because the nvmrc file does not work due to recent changes in `rules_nodejs`. The Bazel NodeJS rules need to compute the Node version at analysis time within Starlark as otherwise the proper toolchains would not be configured, and the fallback Node 14 version would be used.
josephperrott
pushed a commit
that referenced
this pull request
Oct 25, 2021
…)" (#274) This reverts commit 4fee007. Commit is reverted because the nvmrc file does not work due to recent changes in `rules_nodejs`. The Bazel NodeJS rules need to compute the Node version at analysis time within Starlark as otherwise the proper toolchains would not be configured, and the fallback Node 14 version would be used. PR Close #274
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the nvmrc version to set the version of node used in WORKSPACE to more centrally manage the version of node being used.