Skip to content

Commit

Permalink
Revert "build: use nvmrc version to set node version in WORKSPACE (#259
Browse files Browse the repository at this point in the history
…)" (#274)

This reverts commit 4fee007.

Commit is reverted because the nvmrc file does not work due to
recent changes in `rules_nodejs`. The Bazel NodeJS rules need to
compute the Node version at analysis time within Starlark as otherwise
the proper toolchains would not be configured, and the fallback Node 14
version would be used.

PR Close #274
  • Loading branch information
devversion authored and josephperrott committed Oct 25, 2021
1 parent 471437d commit 9277822
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion WORKSPACE
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ http_archive(
load("@build_bazel_rules_nodejs//:index.bzl", "node_repositories", "yarn_install")

node_repositories(
use_nvmrc = "//:.nvmrc",
node_version = "16.10.0",
)

yarn_install(
Expand Down

0 comments on commit 9277822

Please sign in to comment.