Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(bazel): no browsers matching for windows x86_64 cpu #220

Closed
wants to merge 1 commit into from
Closed

fix(bazel): no browsers matching for windows x86_64 cpu #220

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion bazel/browsers/chromium/BUILD.bazel
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ browser(
"@org_chromium_chromedriver_macos_arm64//:metadata",
"@org_chromium_chromium_macos_arm64//:metadata",
],
"//bazel/constraints:windows_x32": [
"//bazel/constraints:windows_x64": [
"@org_chromium_chromedriver_windows//:metadata",
"@org_chromium_chromium_windows//:metadata",
],
Expand Down
1 change: 0 additions & 1 deletion bazel/browsers/firefox/BUILD.bazel
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@ browser(
disabled = select({
# TODO: Consider adding support for Windows. Requires a portable version of
# Firefox. Official distribution only ships with installers.
"//bazel/constraints:windows_x32": "Firefox is not disabled on Windows but always passing",
"//bazel/constraints:windows_x64": "Firefox is not disabled on Windows but always passing",
# Note: We keep always keep others enabled. This will result in proper errors if e.g. a
# linux arm64 machine intends to run tests with Firefox but we miss binaries for the platform.
Expand Down
8 changes: 0 additions & 8 deletions bazel/constraints/BUILD.bazel
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,14 +32,6 @@ config_setting(
],
)

config_setting(
name = "windows_x32",
constraint_values = [
"@platforms//os:windows",
"@platforms//cpu:x86_32",
],
)

# Make source files available for distribution via pkg_npm
filegroup(
name = "files",
Expand Down