fix(bazel): no browsers matching for windows x86_64 cpu #220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With the recent refactorings for supporting M1 browsers, we added our own constraints/config settings. An incorrect assumption was made that the x64 CPU constraint would also match the x32 constraint given that Windows x64 can always run x32 programs. This seems to be not the case (and makes sense in retrospective). This commit fixes the browser configurations by always using x64 instead. The x32 constraint is removed because `rules_webtesting` and other parts of the tooling seem to use x64 windows only, and at this point supporting 32 bit windows seems not wort maintaining/ the additional maintenance.
devversion
added
action: merge
josephperrott
removed
the
action: review
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the recent refactorings for supporting M1 browsers, we
added our own constraints/config settings. An incorrect assumption
was made that the x64 CPU constraint would also match the x32 constraint
given that Windows x64 can always run x32 programs. This seems to be
not the case (and makes sense in retrospective).
This commit fixes the browser configurations by always using x64
instead. The x32 constraint is removed because
rules_webtestingand other parts of the tooling seem to use x64 windows only, and
at this point supporting 32 bit windows seems not wort maintaining/
the additional maintenance.