Run formatter for CHANGELOG.md when generated during release #204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josephperrott
added
action: merge
devversion
reviewed
Sep 4, 2021
josephperrott
force-pushed
the
format-changelog-on-release
branch
5 times, most recently
from
ef8e46d to
110927e
Compare
…onfig function Allow the getConfig function take in a list of assertions functions which will assert against the retrieved config object. Errors from the assertions will be thrown as expected. The returned config object will has the asserted typings. This will allow retrieving the config object already typed, which provides a convenience for cases where getConfig is called on intialization.
…nd checking format of files Returning an exit code to represent the functions failure/success allows for other tooling to utilize the functions in place, previously when process.exit was called directly, it would end the process entirely.
…the changelog Support prepending the release note entries to the changelog.md file. Additionally, we try to run the formatter on the changelog file to ensure that if formatting is required for the file it is completed. Additionally, updating the `ng-dev release notes` command to leverage the newly created `prependEntryToChangelog` method.
josephperrott
force-pushed
the
format-changelog-on-release
branch
from
110927e to
dbc0cd7
Compare
Moves all of the references and instances of testTmpDir to be centralized to using one common symbol. Previously it was defined in two different places and ended up being two different directories.
… to update changelogs during release. Use the appendEntryToChangelog method to update the changelogs, this will enable us to have the logic of managing the changelog file exist in the ReleaseNotes class rather than having the release tool have to understand how to stitch the two together.
…that the temp directory is cleared Creating a bootstrap script for jasmine tests allows us to ensure automatically for all jasmine tests that the temporary directory created for the test runs is cleaned between specs.
josephperrott
force-pushed
the
format-changelog-on-release
branch
from
dbc0cd7 to
98ca7b5
Compare
devversion
reviewed
Sep 8, 2021
tools/jasmine/jasmine.bzl
Outdated
| deps = kwargs.pop("deps", []) + [ | ||
| "//tools/jasmine:bootstrap", | ||
| # Because we don't provided a bundled script, we must ensure that the dependencies for | ||
| # bootstrap are also included as dependencies. |
There was a problem hiding this comment.
Aren't the transitive deps of the bootstrap target automatically unwrapped?
you could simplify this by just depending on the TS target here while still having the other filegroup for the ES5 file above in the templated args (named bootstrap_init_file or something)
There was a problem hiding this comment.
I switched to doing so, though I don't love that we have to still have both dependencies listed here.
…nsures that the temp directory is cleared
…ngelog` to update changelogs during release.
devversion
approved these changes
Sep 9, 2021
devversion
pushed a commit
that referenced
this pull request
Sep 9, 2021
…the changelog (#204) Support prepending the release note entries to the changelog.md file. Additionally, we try to run the formatter on the changelog file to ensure that if formatting is required for the file it is completed. Additionally, updating the `ng-dev release notes` command to leverage the newly created `prependEntryToChangelog` method. PR Close #204
devversion
pushed a commit
that referenced
this pull request
Sep 9, 2021
… to update changelogs during release. (#204) Use the appendEntryToChangelog method to update the changelogs, this will enable us to have the logic of managing the changelog file exist in the ReleaseNotes class rather than having the release tool have to understand how to stitch the two together. PR Close #204
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See individual commits as this change contains a few refactors to make this easier to reason about.
Closes #197