Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code formatting should be run on CHANGELOG.md during release #197

Closed
josephperrott opened this issue Sep 1, 2021 · 2 comments
Closed

Code formatting should be run on CHANGELOG.md during release #197

josephperrott opened this issue Sep 1, 2021 · 2 comments

Comments

@josephperrott
Copy link
Member

During the release process, when the new Changelog entry is generated and added to the CHANGELOG.md file, we should leverage the formatFiles function from ng-dev/format/format to format the newly modified CHANGELOG.md file.

This notably presents as a failure on CI for CLI as markdown files are formatted using prettier.

@josephperrott
Copy link
Member Author

Closed by #204

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Oct 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant