Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better documentation #6530

Closed
wants to merge 1 commit into from
Closed

Better documentation #6530

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion guides/theming.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ Finally, if your app's content **is not** placed inside of a `md-sidenav-contain
need to add the `mat-app-background` class to your wrapper element (for example the `body`). This
ensures that the proper theme background is applied to your page.

### Defining a custom theme
### Step 1: Defining a custom theme
Copy link
Member

@jelbourn jelbourn Aug 23, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Saying "Step 1" doesn't really fit here because it's not in the context of anything that came before it. A better approach would be

### Defining a custom theme

#### Create an scss file for your theme
...
#### Include the generated styles in your application
...

When you want more customization than a pre-built theme offers, you can create your own theme file.

A custom theme file does two things:
Expand Down Expand Up @@ -93,6 +93,7 @@ $candy-app-theme: mat-light-theme($candy-app-primary, $candy-app-accent, $candy-

You only need this single Sass file; you do not need to use Sass to style the rest of your app.

### Step 2: Importing your theme
If you are using the Angular CLI, support for compiling Sass to css is built-in; you only have to
add a new entry to the `"styles"` list in `angular-cli.json` pointing to the theme
file (e.g., `unicorn-app-theme.scss`).
Expand Down