Better documentation #6530
Closed
Better documentation #6530
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Call out that just because a theme file is created does not necessarily mean it is connected to your app.
googlebot
added
the
cla: yes
ghost
mentioned this pull request
jelbourn
reviewed
Aug 23, 2017
| @@ -50,7 +50,7 @@ Finally, if your app's content **is not** placed inside of a `md-sidenav-contain | |||
| need to add the `mat-app-background` class to your wrapper element (for example the `body`). This | |||
| ensures that the proper theme background is applied to your page. | |||
|
|
|||
| ### Defining a custom theme | |||
| ### Step 1: Defining a custom theme | |||
There was a problem hiding this comment.
Saying "Step 1" doesn't really fit here because it's not in the context of anything that came before it. A better approach would be
### Defining a custom theme
#### Create an scss file for your theme
...
#### Include the generated styles in your application
...
|
Closing this since it's become quite stale. Feel free to open a new PR if this is still relevant. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Call out that just because a theme file is created does not necessarily mean it is connected to your app.