Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(table): eliminate need for second change detection #5775

Merged
merged 4 commits into from
Jul 25, 2017
Merged

fix(table): eliminate need for second change detection #5775

merged 4 commits into from
Jul 25, 2017

Conversation

andrewseguin
Copy link
Contributor

@andrewseguin andrewseguin commented Jul 14, 2017 •
edited
Loading

Should fix issue with the router and others since now the table does not assume it will have change detection run twice. Now finishes all of its rendering in one pass

Fixes #5593
Fixes #5914

@andrewseguin andrewseguin requested a review from jelbourn July 14, 2017 22:38
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jul 14, 2017
jelbourn
jelbourn approved these changes Jul 17, 2017
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker and removed pr: needs review labels Jul 17, 2017
@benb7760 benb7760 mentioned this pull request Jul 18, 2017
Closed
@kara kara added the presubmit failures This PR has failures in Google's internal presubmit process and cannot be immediately merged label Jul 20, 2017
@andrewseguin andrewseguin mentioned this pull request Jul 20, 2017
Closed
@benb7760 benb7760 mentioned this pull request Jul 22, 2017
Closed
@matheo
Copy link

matheo commented Jul 22, 2017

Merge please :)

@jelbourn
Copy link
Member

@kara Please add a comment describing the presubmit failures

@kara
Copy link
Contributor

kara commented Jul 24, 2017

One app was failing with "changed after checked" errors. @andrewseguin has already looked into this and has a fix for the app once the next sync goes in.

@andrewseguin andrewseguin merged commit 388494f into angular:master Jul 25, 2017
@rafaelss95 rafaelss95 mentioned this pull request Jul 31, 2017
Closed
@willshowell willshowell mentioned this pull request Aug 1, 2017
Closed
@andrewseguin andrewseguin mentioned this pull request Aug 11, 2017
Closed
@andrewseguin andrewseguin deleted the table-router branch November 28, 2017 20:37
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelbourn jelbourn jelbourn approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement presubmit failures This PR has failures in Google's internal presubmit process and cannot be immediately merged
Projects
None yet
Milestone
No milestone
5 participants
@andrewseguin @matheo @jelbourn @kara @googlebot