You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The text was updated successfully, but these errors were encountered:
willshowell
changed the title
[Table] CdkTable never connects to data source when using OnPush
[Table] CdkTable doesn't automatically connect to data source when using OnPush
Jul 20, 2017
Thanks Will, we've got a PR open that will resolve this - #5775. This was similar to the issue we were having with router changes not rendering the table.
Bug, feature request, or proposal:
Bug
Current behavior
dataSource.connect()
is not subscribed to until the secondngDoCheck
hook, which must be triggered manually when using OnPush in the parent component.Expected behavior
Data source is connected as soon as possible, not requiring an extra check
Workaround
What are the steps to reproduce?
Reproduction: https://plnkr.co/edit/ACvDB3mUsNIIyOC16vpu?p=preview
Workaround: https://plnkr.co/edit/4p0pnAvmfYjIwWMXSqud?p=preview
The text was updated successfully, but these errors were encountered: