feat(datepicker): merge datepicker branch into master #4404

mmalerba · 2017-05-05T22:45:03Z

fxck · 2017-05-06T09:45:28Z

@mmalerba don't you think #4358 should be fixed first? I just tested it again against the angular/material2#datepicker and it's still broken..

use Czech locale using setLocale('cs')
set default value to 2017-05-02T10:10:10.100Z' (2nd of May)
open datepicker and it opens on February

it's basically confusing days for months, I'd say this could imply there could be other locale related problems that tests aren't catching..

* create SimpleDate and CalendarLocale objects * tests * addressed comments * make parseDate more robust * simplify createFormatFunction

* date picker initial commit * month view * added month view functionality * more month view tweaking * started extracting common stuff to calendar-table. * base month view on calendar table * added year view * add disclaimers * addressed comments * fix lint * fixed aot and added comment * started on tests * calendar table tests * tests for month and year view * rebase on top of CalendarLocale & SimpleDate * add some additional functionality to SimpleDate * fix lint * addressed comments * add comment

* date picker initial commit * month view * added month view functionality * more month view tweaking * started extracting common stuff to calendar-table. * base month view on calendar table * added year view * add disclaimers * addressed comments * fix lint * fixed aot and added comment * started on tests * calendar table tests * tests for month and year view * rebase on top of CalendarLocale & SimpleDate * add some additional functionality to SimpleDate * add md-datepicker and input[mdDatepicker] * Add touch UI support * fix some stuff that got messed up in rebasing * addressed comments * move position strategy to separate method * added tests for error cases

* started working on responsive calendar table * fix today, selected, hover styles * fix label positioning * replace em with px * fix today cell styling

…d year views (#2994) * create a calendar component that pulls together month and year views styling still needs some love * fix typo

* style changes * more styles * addressed comments

* enable value propagation through various components & directives * add tests * fix lint * addressed comments * addressed feedback * fix lint * make datepicker selected property internal * add test for pristine after ngModel change

…ut-container (#3468) feat(datepicker): add mdDatepickerToggle & compatibility w/ md-input-container

…r input (#3542) * add aria-* attrs and keyboard bindings to datepicker input * fix rebase errors * added comment

* don't allow going past min/max date * add back missing mdSuffix * added date filtering logic * added working date filter * disabled style for prev/next buttons * add unit tests * fix lint * address comments

…nce (#3685) * fix(datepicker): fix bug where calendar dialog could only be opened once * add rxjs first operator

* add active cell support to calendar-table, month-view, and year-view * stop normalizing the active date in calendar since we now care about the exact active date * add some key handlers * add keyboard support, break some tests * add tests * some finishing touches * fix tabindex * fix rxjs import * addressed some comments * refactor handleKeydown * fix commas

#3854) * fix(datepicker): use input's min & max properites rather than custom ones on md-datepicker * add doc comments

* fix(datepicker): calendar selected date should change when input changes * startAt fix * fix tests * address comments * fix unsubscribe * make valueChange on datepicker-input internal

* add keyboard support, break some tests * add tests * some finishing touches * addressed some comments * separate md-datepicker-content into own component * addressed comments * added some more explanation of the datepicker and datepicker-content components.

* add keyboard support, break some tests * add tests * some finishing touches * addressed some comments * separate md-datepicker-content into own component * fix(datepicker): make touch UI work well on mobile * use vmin instead of media queries + vw, vh * fix non-touch styles * addressed comments * fix lint error about vmin * addressed comments

* prev & next icons with css * add some a11y labels * small fixes * fix sizing

* fix broken tests * md-calendar-table --> [md-calendar-body] * move md-calendar-body to tbody element * move weekdays into table header * finishing touches * fix year view padding * add some comments

* added DateAdapter and NativeDateAdapter * add tests * addressed some comments * more comments addressed * another round of comments addressed * add default formats

…apter (#4189) * rename test file to match the file its testing * remove SimpleDate and CalendarLocale * switch MdMonthView to use DateAdapter * swtich MdYearView to use DateAdapter * switch MdCalendar to use DateAdapter * switch MdDatepicker to use DateAdapter * switch MdDatepickerInput and MdDatepickerToggle to use DateAdapter * fix demo * fix some small bugs * fix tests * alias months in tests * address comments and remove overflow on createDate * s/l10n/intl

…th date adapter into MdNativeDateModule (#4296) * New module structure for DateAdapter. * pass through format options * move date-formats to core/datetime * don't subclass error * add test for missing providers case

* first pass a11y * escape key support * month labels * don't steal focus from fwd/back buttons * fix tests * address some comments * fix lint

* docs(datepicker) update readme * address comments * Add a more comprehensive demo * avoid string date properties in docs

* support validation based on date filter * add validation support for min & max * update docs to talk about validation * fix imports * address comments

mmalerba · 2017-05-09T18:27:43Z

@jelbourn you may want to review these commits more closely: https://github.com/angular/material2/pull/4404/files/14b252336f126d82178a66224f614b6187f2dbc2..0697350b6803a66b0a044888d9f90f615f3d1b84 these are ones I made on top of the already-reviewed changes to fix tests and things.

jelbourn

LGTM, just a couple nits

jelbourn · 2017-05-10T22:05:05Z

src/lib/core/datetime/native-date-adapter.ts

+   * other browsers do not. We remove them to make output consistent and because they interfere with
+   * date parsing.
+   * @param s The string to strip direction characters from.
+   * @returns {string} The stripped string.


Omit return type from comment

jelbourn · 2017-05-10T22:05:36Z

src/lib/core/datetime/native-date-adapter.ts

+   * @param s The string to strip direction characters from.
+   * @returns {string} The stripped string.
+   */
+  private _stripDirectionCharacters(s: string) {


_stripDirectionalityCharacters? (to match our pending terminology)

mmalerba · 2017-05-10T23:18:26Z

Done

angular-automatic-lock-bot · 2019-09-07T22:01:13Z

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}

mmalerba added the pr: needs review label May 5, 2017

mmalerba assigned jelbourn May 5, 2017

mmalerba requested a review from jelbourn May 5, 2017 22:45

googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label May 5, 2017

mmalerba force-pushed the datepicker branch 5 times, most recently from 35ae5ff to 205195f Compare May 9, 2017 16:33

mmalerba added 20 commits May 9, 2017 10:48

create SimpleDate and CalendarLocale objects (#2839)

869d0f2

* create SimpleDate and CalendarLocale objects * tests * addressed comments * make parseDate more robust * simplify createFormatFunction

fixes i forgot to push before merging #2904 (#2978)

fc34721

feat(datepicker): make calendar responsive (#3086)

16a16c6

* started working on responsive calendar table * fix today, selected, hover styles * fix label positioning * replace em with px * fix today cell styling

feat(datepicker): add calendar component that pulls together month an…

bcff6be

…d year views (#2994) * create a calendar component that pulls together month and year views styling still needs some love * fix typo

fix(datepicker): make calendar look more like mocks (#3138)

58456ea

* style changes * more styles * addressed comments

add the calendar to the datepicker popup (#3178)

bc4b168

feat(datepicker): add md-datepicker-trigger & compatibility w/ md-inp…

4c20c5f

…ut-container (#3468) feat(datepicker): add mdDatepickerToggle & compatibility w/ md-input-container

feat(datepicker): add aria-* attrs and keyboard bindings to datepicke…

991cdde

…r input (#3542) * add aria-* attrs and keyboard bindings to datepicker input * fix rebase errors * added comment

feat(datepicker): min & max dates + dateFilter (#3556)

4aeca6c

* don't allow going past min/max date * add back missing mdSuffix * added date filtering logic * added working date filter * disabled style for prev/next buttons * add unit tests * fix lint * address comments

fix(datepicker): fix bug where calendar dialog could only be opened o…

e6cf1ef

…nce (#3685) * fix(datepicker): fix bug where calendar dialog could only be opened once * add rxjs first operator

angular 4 fixes

21cb164

fix(datepicker): use input's min & max properites rather than custom … (

dbb8387

#3854) * fix(datepicker): use input's min & max properites rather than custom ones on md-datepicker * add doc comments

fix(datepicker): hide weekdays in year view (#3852)

559880d

fix(datepicker): calendar should update when input changes (#3824)

a85c094

* fix(datepicker): calendar selected date should change when input changes * startAt fix * fix tests * address comments * fix unsubscribe * make valueChange on datepicker-input internal

mmalerba added 16 commits May 9, 2017 10:48

fix lint issues

776a10a

fix(datepicker): some misc cleanup (#4106)

5f39247

* prev & next icons with css * add some a11y labels * small fixes * fix sizing

refactor(datepicker): move weekdays into table header (#4129)

8b6780c

* fix broken tests * md-calendar-table --> [md-calendar-body] * move md-calendar-body to tbody element * move weekdays into table header * finishing touches * fix year view padding * add some comments

feat(datepicker): add DateAdapter and NativeDateAdapter (#4148)

f229b1b

* added DateAdapter and NativeDateAdapter * add tests * addressed some comments * more comments addressed * another round of comments addressed * add default formats

fix lint issues

2642715

fix(datepicker): make datepicker work with screen readers (#4349)

ac706fe

* first pass a11y * escape key support * month labels * don't steal focus from fwd/back buttons * fix tests * address some comments * fix lint

docs(datepicker): update readme & demo (#4368)

a6428e5

* docs(datepicker) update readme * address comments * Add a more comprehensive demo * avoid string date properties in docs

fix(datepicker): require actual date objects for min, max, etc (#4381)

7964052

feat(datepicker): input validation for min, max, and date filter (#4393)

14b2523

* support validation based on date filter * add validation support for min & max * update docs to talk about validation * fix imports * address comments

refactor(datepicker): migrate from Renderer to Renderer2

7fe110a

fix tests on safari 9

361a05b

fix Edge/IE tests that fail because of different Intl implementation

4f5ccb2

strip direction characters when formatting

9bbed07

fix lint

0697350

mmalerba force-pushed the datepicker branch from 4fe85cf to 0697350 Compare May 9, 2017 17:52

jelbourn approved these changes May 10, 2017

View reviewed changes

jelbourn added pr: lgtm and removed pr: needs review labels May 10, 2017

addressed comments

3b31d7b

mmalerba added the action: merge The PR is ready for merge by the caretaker label May 11, 2017

kara merged commit 123d7ec into master May 12, 2017

josephperrott pushed a commit to josephperrott/components that referenced this pull request May 12, 2017

feat(datepicker): merge datepicker branch into master (angular#4404)

141fe87

oKcerG mentioned this pull request Jul 20, 2017

DatePicker calendar view and DatePickerDialog lirios/fluid#77

Closed

jelbourn deleted the datepicker branch December 7, 2017 23:46

angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 7, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(datepicker): merge datepicker branch into master #4404

feat(datepicker): merge datepicker branch into master #4404

mmalerba commented May 5, 2017

fxck commented May 6, 2017 •

edited

Loading

mmalerba commented May 9, 2017

jelbourn left a comment

jelbourn May 10, 2017

jelbourn May 10, 2017

mmalerba commented May 10, 2017

angular-automatic-lock-bot bot commented Sep 7, 2019

feat(datepicker): merge datepicker branch into master #4404

feat(datepicker): merge datepicker branch into master #4404

Conversation

mmalerba commented May 5, 2017

fxck commented May 6, 2017 • edited Loading

mmalerba commented May 9, 2017

jelbourn left a comment

Choose a reason for hiding this comment

jelbourn May 10, 2017

Choose a reason for hiding this comment

jelbourn May 10, 2017

Choose a reason for hiding this comment

mmalerba commented May 10, 2017

angular-automatic-lock-bot bot commented Sep 7, 2019

fxck commented May 6, 2017 •

edited

Loading