feat(datepicker): input validation for min, max, and date filter #4393
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
kara
reviewed
May 5, 2017
| placeholder="Pick a date"> | ||
| <md-error *ngIf="resultPickerModel.errors?.mdDatepickerMin">Too early!</md-error> |
There was a problem hiding this comment.
It might be easier to just use resultPickerModel.hasError('mdDatepickerMin')
src/lib/datepicker/datepicker.md
Outdated
| ``` | ||
|
|
||
| In this example the user can back past 2005, but all of the dates before then will be unselectable. | ||
| They will not be able to go further back in the calendar than 2000. | ||
| They will not be able to go further back in the calendar than 2000. If they manually type in a date | ||
| that is before the min, after the max, or filtered out the input will have validation errors. |
There was a problem hiding this comment.
Nit: or filtered out, the input will ...
src/lib/datepicker/datepicker.md
Outdated
| Each validation property has a different error that can be checked: | ||
| * A value that violates the `min` property will have a `mdDatepickerMin` error. | ||
| * A value that violates the `max` property will have a `mdDatepickerMax` error. | ||
| * A value that violates the `mdDatepickerFilter` property will have a `mdDatepickerFitler` error. |
There was a problem hiding this comment.
Typo: mdDatepickerFitler => mdDatepickerFilter
src/lib/datepicker/datepicker.md
Outdated
| calendar past that point. | ||
| A result of `true` indicates that the date is valid and a result of `false` indicates that it is | ||
| not. Again this will also disable the dates on the calendar that are invalid. However, one important | ||
| difference between using `mdDatepcikerFilter` vs using `min` or `max` is that filtering out all |
There was a problem hiding this comment.
Typo: mdDatepcikerFilter -> mdDatepickerFilter
| (control: AbstractControl): ValidationErrors | null => { | ||
| return !this._dateFilter || !control.value || this._dateFilter(control.value) ? | ||
| null : {'mdDatepickerFilter': true}; | ||
| }, |
There was a problem hiding this comment.
Have you thought about breaking these validator functions out into their own methods or getters? This is a bit hard to scan.
|
comments addressed |
mmalerba
added a commit
that referenced
this pull request
May 5, 2017
* support validation based on date filter * add validation support for min & max * update docs to talk about validation * fix imports * address comments
mmalerba
added a commit
that referenced
this pull request
May 9, 2017
* support validation based on date filter * add validation support for min & max * update docs to talk about validation * fix imports * address comments
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.