Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(material/datepicker): use SVG icons for calendar #29957

Merged
merged 1 commit into from
Nov 4, 2024

Conversation

crisbeto
Copy link
Member

@crisbeto crisbeto commented Nov 1, 2024

The calendar's next/previous icons are currently rendered using an :after element, borders and a transform. This makes them hard to position accurately and fragile to changes in the container size. These changes switch to using SVG which is more robust.

Fixes #29956.

The calendar's next/previous icons are currently rendered using an `:after` element, borders and a transform. This makes them hard to position accurately and fragile to changes in the container size. These changes switch to using SVG which is more robust.

Fixes angular#29956.
@crisbeto crisbeto added the target: patch This PR is targeted for the next patch release label Nov 1, 2024
@crisbeto crisbeto requested a review from a team as a code owner November 1, 2024 14:22
@crisbeto crisbeto requested review from amysorto and wagnermaciel and removed request for a team November 1, 2024 14:22
@crisbeto crisbeto removed the request for review from wagnermaciel November 4, 2024 08:01
@crisbeto crisbeto added the action: merge The PR is ready for merge by the caretaker label Nov 4, 2024
@crisbeto crisbeto merged commit 4d3c22c into angular:main Nov 4, 2024
25 checks passed
crisbeto added a commit that referenced this pull request Nov 4, 2024
The calendar's next/previous icons are currently rendered using an `:after` element, borders and a transform. This makes them hard to position accurately and fragile to changes in the container size. These changes switch to using SVG which is more robust.

Fixes #29956.

(cherry picked from commit 4d3c22c)
crisbeto added a commit that referenced this pull request Nov 4, 2024
The calendar's next/previous icons are currently rendered using an `:after` element, borders and a transform. This makes them hard to position accurately and fragile to changes in the container size. These changes switch to using SVG which is more robust.

Fixes #29956.

(cherry picked from commit 4d3c22c)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Dec 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release
Projects
None yet
2 participants