Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug(COMPONENT): mat-datepicker does not render the previous < and next > icon correctly when set theme density: (scale: -2) and beyond #29956

Closed
1 task done
koumoua01 opened this issue Nov 1, 2024 · 2 comments · Fixed by #29957
Closed
1 task done

bug(COMPONENT): mat-datepicker does not render the previous < and next > icon correctly when set theme density: (scale: -2) and beyond #29956

koumoua01 opened this issue Nov 1, 2024 · 2 comments · Fixed by #29957
Assignees
@crisbeto
Labels
area: material/datepicker P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent

Comments

@koumoua01
Copy link

Is this a regression?

  • Yes, this behavior used to work in the previous version

The previous version in which this bug was not present was

No response

Description

Image

Reproduction

StackBlitz link:
Steps to reproduce:
1.
2.

Expected Behavior

render the button icon correctly

Actual Behavior

does not render the button icon correctly

Environment

  • Angular:
  • CDK/Material:
  • Browser(s):
  • Operating System (e.g. Windows, macOS, Ubuntu):
@koumoua01 koumoua01 added the needs triage This issue needs to be triaged by the team label Nov 1, 2024
@koumoua01
Copy link
Author

my solution: .mat-calendar-previous-button::after,
.mat-calendar-next-button::after {
margin: 10px !important; // for density -3
}

@crisbeto crisbeto self-assigned this Nov 1, 2024
@crisbeto crisbeto added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent area: material/datepicker and removed needs triage This issue needs to be triaged by the team labels Nov 1, 2024
crisbeto added a commit to crisbeto/material2 that referenced this issue Nov 1, 2024
@crisbeto
fix(material/datepicker): use SVG icons for calendar
0315f2c 
The calendar's next/previous icons are currently rendered using an `:after` element, borders and a transform. This makes them hard to position accurately and fragile to changes in the container size. These changes switch to using SVG which is more robust.

Fixes angular#29956.
@crisbeto crisbeto mentioned this issue Nov 1, 2024
Merged
@koumoua01 koumoua01 changed the title bug(COMPONENT): mat-datepicker does not render the previews < and next > icon correctly when set theme density: (scale: -2) and beyond bug(COMPONENT): mat-datepicker does not render the previous < and next > icon correctly when set theme density: (scale: -2) and beyond Nov 1, 2024
crisbeto added a commit that referenced this issue Nov 4, 2024
@crisbeto
fix(material/datepicker): use SVG icons for calendar (#29957)
4d3c22c 
The calendar's next/previous icons are currently rendered using an `:after` element, borders and a transform. This makes them hard to position accurately and fragile to changes in the container size. These changes switch to using SVG which is more robust.

Fixes #29956.
crisbeto added a commit that referenced this issue Nov 4, 2024
@crisbeto
fix(material/datepicker): use SVG icons for calendar (#29957)
d8dedc9 
The calendar's next/previous icons are currently rendered using an `:after` element, borders and a transform. This makes them hard to position accurately and fragile to changes in the container size. These changes switch to using SVG which is more robust.

Fixes #29956.

(cherry picked from commit 4d3c22c)
crisbeto added a commit that referenced this issue Nov 4, 2024
@crisbeto
fix(material/datepicker): use SVG icons for calendar (#29957)
3fc968a 
The calendar's next/previous icons are currently rendered using an `:after` element, borders and a transform. This makes them hard to position accurately and fragile to changes in the container size. These changes switch to using SVG which is more robust.

Fixes #29956.

(cherry picked from commit 4d3c22c)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Dec 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@crisbeto crisbeto

Labels
area: material/datepicker P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(material/datepicker): use SVG icons for calendar crisbeto/material2
2 participants
@crisbeto @koumoua01