feature(material-experimental/chips) Add grid keyboard shortcuts

[vanessanschmitt]

No description provided.

[vanessanschmitt]

@jelbourn

[vanessanschmitt]

related to #16173

[jelbourn]

Here's my initial pass; I think I still have some details to look at more closely

[jelbourn]

I just noticed this example (copied from the old implementation) is wrong. The element should be a button.

[vanessanschmitt]

The mat-icon element should be a button? This example matches the demo, which seems to work well: https://github.com/angular/components/blob/master/src/dev-app/chips/chips-demo.html#L47

I did put 'role': 'button' on the host element for matChipRemove:
https://github.com/angular/components/pull/16384/files#diff-350c9b188f681cf2a48614ce9b6a4cffR100

[jelbourn]

Adding the role also works, it's just a style thing. We typically tell people to do

<button mat-icon-button aria-label="...">
  <mat-icon>...</mat-icon>
</button>

rather than putting click handlers on icons directly; it's mostly about setting a good example

[vanessanschmitt]

That makes sense! The mdc classes right now don't play nicely with mat-icon-button. Can I fix this in a follow up PR? @jelbourn

[vanessanschmitt]

Style question: What are the rules for prefixing private/internal variables and methods with _?

[vanessanschmitt]

@jelbourn Just noting that I addressed the requested changes!

[jelbourn]

Overall looks good, just one or two last nits

[jelbourn]

We use an underscore for any non-public member, which includes both real private and the pretend "internal" members we have. Ideally we'd have to real way to mark things as "only usable within this package", but no such construct exists.

[jelbourn]

LGTM

[angular-automatic-lock-bot]

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}