Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build MDC-based chips #16173

Closed
1 of 14 tasks
jelbourn opened this issue May 31, 2019 · 2 comments
Closed
1 of 14 tasks

Build MDC-based chips #16173

jelbourn opened this issue May 31, 2019 · 2 comments
Assignees
Labels
area: material/chips feature This issue represents a new feature or feature request rather than a bug or bug fix P2 The issue is important to a large percentage of users, with a workaround

Comments

@jelbourn
Copy link
Member

jelbourn commented May 31, 2019

Tasks

  • Scaffold empty classes, assets, demo, build config, etc.
  • Stub existing component API
  • Hook up MDC foundation and adapter
  • Add remaining features on top of MDC implementation
  • Test dark theme
  • Test RTL
  • Test with screen-readers
  • Copy existing unit tests and ensure they all pass
  • Copy existing e2e tests and ensure they all pass (if any)
  • Verify SSR support in universal-app/
  • Verify no size regression
  • Create test harness
  • Create schematics for migration
  • Create user documentation

Additional notes

  • The current chips implementation uses role="listbox". For the MDC-based version, we want to introduce different interaction-pattern variants, e.g.
<!-- role="grid" -->
<mat-chip-grid>
  <mat-chip-cell> ... </mat-chip-cell>
</mat-chip-grid>

<!-- role="listbox" -->
<mat-chip-listbox>
  <mat-chip-option> ... </mat-chip-option>
</mat-chip-listbox>

All of the variants of the chip-set/chip should extend from one common base.

  • We likely want to remove the idea of selected from the base chip since it only really applies in the listbox model

Breaking changes

Known issues & visual differences

@jelbourn jelbourn added the feature This issue represents a new feature or feature request rather than a bug or bug fix label May 31, 2019
@vanessanschmitt
Copy link
Collaborator

vanessanschmitt commented Jun 25, 2019

Status update:

Tasks

  • Scaffold empty classes, assets, demo, build config, etc.
  • Stub existing component API
  • Hook up MDC foundation and adapter
  • Add remaining features on top of MDC implementation
  • Test dark theme
  • Test RTL
  • Test with screen-readers
  • Copy existing unit tests and ensure they all pass
  • Copy existing e2e tests and ensure they all pass (if any)
  • Verify SSR support in universal-app/
  • Verify no size regression
  • Create test harness
  • Create schematics for migration
  • Create user documentation

@mmalerba mmalerba added the needs triage This issue needs to be triaged by the team label May 20, 2020
@crisbeto crisbeto added area: material/chips Fixed in MDC and removed needs triage This issue needs to be triaged by the team labels May 27, 2020
@devversion devversion added the P2 The issue is important to a large percentage of users, with a workaround label May 28, 2020
@jelbourn jelbourn closed this as completed Mar 9, 2021
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Apr 9, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area: material/chips feature This issue represents a new feature or feature request rather than a bug or bug fix P2 The issue is important to a large percentage of users, with a workaround
Projects
None yet
Development

No branches or pull requests

5 participants