refactor(language-service): [Ivy] remove temporary compiler #38310
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyliau
added
area: language-service
kyliau
commented
Jul 31, 2020
kyliau
force-pushed
the
ivy-ls-template-typechecker
branch
from
454d176 to
a0b5e5e
Compare
ayazhafiz
reviewed
Jul 31, 2020
|
LGTM, +me after comments are resolved |
kyliau
commented
Aug 14, 2020
There was a problem hiding this comment.
@ayazhafiz could you please take another look? Sorry I was OOO last week.
kyliau
force-pushed
the
ivy-ls-template-typechecker
branch
from
a0b5e5e to
938a247
Compare
ayazhafiz
approved these changes
Aug 15, 2020
gkalpak
approved these changes
Aug 17, 2020
gkalpak
added
action: cleanup
kyliau
removed
the
action: cleanup
kyliau
changed the title
Now that Ivy compiler has a proper `TemplateTypeChecker` interface (see angular#38105) we no longer need to keep the temporary compiler implementation. The temporary compiler was created to enable testing infrastructure to be developed for the Ivy language service. This commit removes the whole `ivy/compiler` directory and moves two functions `createTypeCheckingProgramStrategy` and `getOrCreateTypeCheckScriptInfo` to the `LanguageService` class. Also re-enable the Ivy LS test since it's no longer blocking development.
kyliau
force-pushed
the
ivy-ls-template-typechecker
branch
from
938a247 to
7bcd757
Compare
atscott
pushed a commit
that referenced
this pull request
Aug 17, 2020
Now that Ivy compiler has a proper `TemplateTypeChecker` interface (see #38105) we no longer need to keep the temporary compiler implementation. The temporary compiler was created to enable testing infrastructure to be developed for the Ivy language service. This commit removes the whole `ivy/compiler` directory and moves two functions `createTypeCheckingProgramStrategy` and `getOrCreateTypeCheckScriptInfo` to the `LanguageService` class. Also re-enable the Ivy LS test since it's no longer blocking development. PR Close #38310
subratpalhar92
pushed a commit
to SUBRATPALHAR-ALL-JAVASCRIPT/angular
that referenced
this pull request
Aug 29, 2020
…38310) Now that Ivy compiler has a proper `TemplateTypeChecker` interface (see angular#38105) we no longer need to keep the temporary compiler implementation. The temporary compiler was created to enable testing infrastructure to be developed for the Ivy language service. This commit removes the whole `ivy/compiler` directory and moves two functions `createTypeCheckingProgramStrategy` and `getOrCreateTypeCheckScriptInfo` to the `LanguageService` class. Also re-enable the Ivy LS test since it's no longer blocking development. PR Close angular#38310
subratpalhar92
added a commit
to SUBRATPALHAR-ALL-JAVASCRIPT/angular
that referenced
this pull request
Aug 31, 2020
…ngular#38310)" This reverts commit 42e16b6.
subratpalhar92
pushed a commit
to SUBRATPALHAR-ALL-JAVASCRIPT/angular
that referenced
this pull request
Aug 31, 2020
…38310) Now that Ivy compiler has a proper `TemplateTypeChecker` interface (see angular#38105) we no longer need to keep the temporary compiler implementation. The temporary compiler was created to enable testing infrastructure to be developed for the Ivy language service. This commit removes the whole `ivy/compiler` directory and moves two functions `createTypeCheckingProgramStrategy` and `getOrCreateTypeCheckScriptInfo` to the `LanguageService` class. Also re-enable the Ivy LS test since it's no longer blocking development. PR Close angular#38310
profanis
pushed a commit
to profanis/angular
that referenced
this pull request
Sep 5, 2020
…38310) Now that Ivy compiler has a proper `TemplateTypeChecker` interface (see angular#38105) we no longer need to keep the temporary compiler implementation. The temporary compiler was created to enable testing infrastructure to be developed for the Ivy language service. This commit removes the whole `ivy/compiler` directory and moves two functions `createTypeCheckingProgramStrategy` and `getOrCreateTypeCheckScriptInfo` to the `LanguageService` class. Also re-enable the Ivy LS test since it's no longer blocking development. PR Close angular#38310
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that Ivy compiler has a proper
TemplateTypeCheckerinterface(see #38105) we no longer need to
keep the temporary compiler implementation.
The temporary compiler was created to enable testing infrastructure to
be developed for the Ivy language service.
This commit removes the whole
ivy/compilerdirectory and moves twofunctions
createTypeCheckingProgramStrategyandgetOrCreateTypeCheckScriptInfoto theLanguageServiceclass.Also re-enable the Ivy LS test since it's no longer blocking development.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information