Skip to content

Commit

Permalink
refactor(language-service): [Ivy] remove temporary compiler (#38310)
Browse files Browse the repository at this point in the history
Now that Ivy compiler has a proper `TemplateTypeChecker` interface
(see #38105) we no longer need to
keep the temporary compiler implementation.

The temporary compiler was created to enable testing infrastructure to
be developed for the Ivy language service.

This commit removes the whole `ivy/compiler` directory and moves two
functions `createTypeCheckingProgramStrategy` and
`getOrCreateTypeCheckScriptInfo` to the `LanguageService` class.

Also re-enable the Ivy LS test since it's no longer blocking development.

PR Close #38310
  • Loading branch information
kyliau authored and atscott committed Aug 17, 2020
1 parent b32126c commit 84d1ba7
Show file tree
Hide file tree
Showing 7 changed files with 119 additions and 261 deletions.
8 changes: 7 additions & 1 deletion packages/language-service/ivy/BUILD.bazel
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,13 @@ ts_library(
srcs = glob(["*.ts"]),
deps = [
"//packages/compiler-cli",
"//packages/language-service/ivy/compiler",
"//packages/compiler-cli/src/ngtsc/core",
"//packages/compiler-cli/src/ngtsc/core:api",
"//packages/compiler-cli/src/ngtsc/file_system",
"//packages/compiler-cli/src/ngtsc/incremental",
"//packages/compiler-cli/src/ngtsc/shims",
"//packages/compiler-cli/src/ngtsc/typecheck",
"//packages/compiler-cli/src/ngtsc/typecheck/api",
"@npm//typescript",
],
)
17 changes: 0 additions & 17 deletions packages/language-service/ivy/compiler/BUILD.bazel

This file was deleted.

2 changes: 0 additions & 2 deletions packages/language-service/ivy/compiler/README.md

This file was deleted.

124 changes: 0 additions & 124 deletions packages/language-service/ivy/compiler/compiler.ts

This file was deleted.

103 changes: 0 additions & 103 deletions packages/language-service/ivy/compiler/compiler_host.ts

This file was deleted.

Loading

0 comments on commit 84d1ba7

Please sign in to comment.