This repository has been archived by the owner on Apr 12, 2024. It is now read-only.
fix(jqLite.attr): ignore comment, text and attribute nodes when setting/... #11275
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -587,6 +587,9 @@ forEach({ | |||
| }, | |||
|
|
|||
| attr: function(element, name, value) { | |||
| if (element.nodeType === 2 || element.nodeType === 3 || element.nodeType === 8) { | |||
There was a problem hiding this comment.
- please use
NODE_TYPE_TEXTandNODE_TYPE_COMMENT, for nodeType === 2, please createNODE_TYPE_ATTRIBUTEto src/Angular.js and use it - add
var nodeType = element.nodeTypeand do the comparison to it
|
otherwise, LGTM |
…ng/getting attributes follow jQuery handling of the attr function Fixes #11038
|
Done. 😆 |
|
landed as bb5bf7f |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...getting attributes
follow jQuery handling of the attr function
Fixes #11038