JQLite issue setting attributes on comments ¯\_(ツ)_/¯

[kentcdodds]

Here's a demo of the issue (open the console) and you'll see something like this (asside from all the jsbin logs):

This is referencing this line which chokes if the element is a comment (evidently). jQuery proper handles this (somehow). If you edit the jsbin, simply uncomment the script tag to include jQuery and you'll see that the error is now gone.

I apologize if the demo is a little contrived, it was how I discovered the bug.

[Pumpuli]

jQuery bails on comment elements https://github.com/jquery/jquery/blob/0c466438d1feaec302fec13eafeeb063bbfd6a19/src/attributes/attr.js#L30

[kentcdodds]

Thanks @Pumpuli

[Narretz]

Okay, so we should probably do the same thing. At first I thought this was an ngMessages bug, but this isn't so bad.

[RobiFerentz]

I'm trying to push a branch with a fix for this issue so I can create a pull request. (gotta start somewhere with the contributing thing.)
Getting a 403 when trying. Who do I need to bribe to get permission?

[Narretz]

Hi @RobiFerentz, it usually works like this: you fork angular.js on Github. Then you set your fork as a remote on your local repo and push your bug fix branch to your fork. Back on github, you can now open a PR.

[RobiFerentz]

Yeah, forgot that part. Too early in the morning.

[kentcdodds]

Thanks for the PR @RobiFerentz! It'll be nice to get this fixed.

[kentcdodds]

👏 Thanks!