Skip to content
This repository has been archived by the owner on Apr 12, 2024. It is now read-only.

ngAnimate doesn't cache failed animations to avoid addClass/removeClass #14165

Closed
matsko opened this issue Mar 3, 2016 · 0 comments · Fixed by angular-indonesia/angular.js#159 or javascript-indonesias/angular.js#104
Closed

ngAnimate doesn't cache failed animations to avoid addClass/removeClass #14165

matsko opened this issue Mar 3, 2016 · 0 comments · Fixed by angular-indonesia/angular.js#159 or javascript-indonesias/angular.js#104
Assignees
@Narretz
Labels
component: ngAnimate type: perf
Milestone
1.7.x

Comments

@matsko
Copy link
Contributor

matsko commented Mar 3, 2016

Note: for support questions, please use one of these channels: https://github.com/angular/angular.js/blob/master/CONTRIBUTING.md#question. This repository's issues are reserved for feature requests and bug reports.

  • Do you want to request a feature or report a bug?
  • What is the current behavior?
  • If the current behavior is a bug, please provide the steps to reproduce and if possible a minimal demo of the problem via
    https://plnkr.co or similar (you can use this template as a starting point: http://plnkr.co/edit/tpl:yBpEi4).
  • What is the expected behavior?
  • What is the motivation / use case for changing the behavior?
  • Which version of Angular, and which browser and OS does this issue affect? Did this work in previous
    versions of Angular? Please also test with the latest stable and snapshot versions.
  • Other information (e.g. detailed explanation, stacktraces, related issues, suggestions how to fix)
matsko added a commit to matsko/angular.js that referenced this issue Mar 3, 2016
@matsko
perf(ngAnimate): cache repeated calls to addClass/removeClass
e58c06b 
Closes angular#14165
@matsko matsko mentioned this issue Mar 3, 2016
Closed
matsko added a commit to matsko/angular.js that referenced this issue Mar 3, 2016
@matsko
perf(ngAnimate): cache repeated calls to addClass/removeClass
4745a0d 
Applies to 1.4.x and 1.5.x and master

Closes angular#14165
Closes angular#14166
matsko added a commit to matsko/angular.js that referenced this issue Mar 3, 2016
@matsko
perf(ngAnimate): cache repeated calls to addClass/removeClass
0f15476 
Applies to 1.4.x and 1.5.x and master

Closes angular#14165
Closes angular#14166
matsko added a commit to matsko/angular.js that referenced this issue Mar 3, 2016
@matsko
perf(ngAnimate): cache repeated calls to addClass/removeClass
1d766cf 
Applies to 1.4.x and 1.5.x and master

Closes angular#14165
Closes angular#14166
@Narretz Narretz added this to the 1.5.x milestone Mar 3, 2016
@Narretz Narretz modified the milestones: 1.5.x, 1.6.x Mar 31, 2017
@Narretz Narretz modified the milestones: 1.6.x, 1.7.x Apr 12, 2018
@Narretz Narretz self-assigned this May 3, 2018
Narretz pushed a commit to Narretz/angular.js that referenced this issue May 18, 2018
@matsko @Narretz
perf(ngAnimate): avoid repeated calls to addClass/removeClass when an…
64d98fb 
…imation has no duration

Background:
ngAnimate writes helper classes to DOM elements to see if animations are defined on them. If many
elements have the same definition, we can cache the definition and skip the application of the
helper classes altogether. This helps particularly with large ngRepeat collections.

Closes angular#14165
Closes angular#14166
Narretz pushed a commit to Narretz/angular.js that referenced this issue Jun 25, 2018
@matsko @Narretz
perf(ngAnimate): avoid repeated calls to addClass/removeClass when an…
ba37426 
…imation has no duration

Background:
ngAnimate writes helper classes to DOM elements to see if animations are defined on them. If many
elements have the same definition, we can cache the definition and skip the application of the
helper classes altogether. This helps particularly with large ngRepeat collections.

Closes angular#14165
Closes angular#14166
@Narretz Narretz mentioned this issue Jun 25, 2018
Closed
3 tasks
Narretz pushed a commit to Narretz/angular.js that referenced this issue Jul 3, 2018
@matsko @Narretz
perf(ngAnimate): avoid repeated calls to addClass/removeClass when an…
b13a6fa 
…imation has no duration

Background:
ngAnimate writes helper classes to DOM elements to see if animations are defined on them. If many
elements have the same definition, we can cache the definition and skip the application of the
helper classes altogether. This helps particularly with large ngRepeat collections.

Closes angular#14165
Closes angular#14166
Narretz pushed a commit to Narretz/angular.js that referenced this issue Jul 4, 2018
@matsko @Narretz
perf(ngAnimate): avoid repeated calls to addClass/removeClass when an…
9463045 
…imation has no duration

Background:
ngAnimate writes helper classes to DOM elements to see if animations are defined on them. If many
elements have the same definition, we can cache the definition and skip the application of the
helper classes altogether. This helps particularly with large ngRepeat collections.

Closes angular#14165
Closes angular#14166
@Narretz Narretz closed this as completed in 0e26197 Jul 5, 2018
Narretz pushed a commit that referenced this issue Jul 5, 2018
@matsko @Narretz
perf(ngAnimate): avoid repeated calls to addClass/removeClass when an…
0936353 
…imation has no duration

Background:
ngAnimate writes helper classes to DOM elements to see if animations are defined on them. If many
elements have the same definition, and the same parent, we can cache the definition and skip the
application of the helper classes altogether. This helps particularly with large ngRepeat
collections.

Closes #14165
Closes #14166
Closes #16613
This was referenced Jul 6, 2018
Merged
Merged
@dependencies dependencies bot mentioned this issue Aug 9, 2018
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Narretz Narretz

Labels
component: ngAnimate type: perf
Projects
None yet
Milestone
1.7.x
2 participants
@matsko @Narretz