-
Notifications
You must be signed in to change notification settings - Fork 12k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(@angular/cli): add scope hoisting via webpack 3 #6365
Conversation
78e6b0f
to
f926c06
Compare
f926c06
to
4f2dbed
Compare
@@ -97,11 +97,11 @@ export function getCommonConfig(wco: WebpackConfigOptions) { | |||
].concat(extraPlugins), | |||
node: { | |||
fs: 'empty', | |||
global: true, | |||
global: 'empty', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
global only supports a boolean. Ref: https://webpack.js.org/configuration/node/#node-global
22d4663
to
2c588dc
Compare
bfb15ba
to
e429c1d
Compare
It seems they released Scope hoisting and blog posted about it |
e429c1d
to
6ca8d07
Compare
Pushed an update that uses |
6ca8d07
to
9c1872b
Compare
We have a few PRs we are hoping to land within this next few weeks. It should good the perf regressions, in theory. |
9c1872b
to
91af4ca
Compare
@filipesilva - Changelog for html-webpack-plugin was waiting on webpack-contrib/extract-text-webpack-plugin#540, I put a note in that PR as well. less-loader will be sorted this weekend. |
fa2b8af
to
9e4ebc6
Compare
858cf66
to
0230806
Compare
d0d2723
to
d371493
Compare
@filipesilva - You can check less-loader off your list https://github.com/webpack-contrib/less-loader/releases/tag/v4.0.5 Extract Text will make the |
d371493
to
186056f
Compare
@d3viant0ne thank you for the heads up, I just updated this PR to use |
186056f
to
244c6a0
Compare
This PR no longer automatically turn off vendor chunking in production builds, since it's benefits might be conditional on a bug that needs to be fixed. This can be added at a future date if needed. |
This should result in significant bundle size reduction. For best results, build for production with `--vendor-chunk=false`. See https://medium.com/webpack/webpack-3-official-release-15fd2dd8f07b for details.
244c6a0
to
79db553
Compare
Updated to I'd like to extend my thanks to @d3viant0ne and @TheLarkInn, they've been awesome in communicating changes and releases in the Webpack 3 rollout, cheers! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This should result in significant bundle size reduction. For best results, build for production with
--vendor-chunk=false
.See https://medium.com/webpack/webpack-3-official-release-15fd2dd8f07b for details.
Blockers for this to get merged:
Webpack 2.5.1+ bug with CommonsChunkPlugin webpack 2.5.1 can't use async CommonsChunkPlugin webpack/webpack#4850 fixed, it's breaking(not a bug, just config CommonsChunkPlugin in async mode doesn't select initial chunks caused a bug in expected behvaior webpack/webpack#5109 (comment))tests/e2e/tests/misc/common-async.ts
(not applicable to CLI projects [webpack v3.0.0] generates CSS in wrong order webpack-contrib/extract-text-webpack-plugin#548 (comment))extract-text-webpack-plugin
generates css in the wrong order [webpack v3.0.0] generates CSS in wrong order webpack-contrib/extract-text-webpack-plugin#548[email protected]
as a peer dependency:extract-text-webpack-plugin
: refactor: Apply webpack-defaults & webpack 3.x support webpack-contrib/extract-text-webpack-plugin#540html-webpack-plugin
: Update to webpack 3 jantimon/html-webpack-plugin#707less-loader
: chore(package): updatedefaults 1.4.0
support Webpack@3 webpack-contrib/less-loader#208webpack-dev-middleware
: chore(package): updatepeerDependencies
(webpack v3.0.0
) webpack/webpack-dev-middleware#200webpack-dev-server
: Update to webpack 3 webpack/webpack-dev-server#946