fix(init): ignore favicon #2617
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
filipesilva
suggested changes
Oct 10, 2016
| @@ -105,7 +105,8 @@ const InitCommand: any = Command.extend({ | |||
| mobile: commandOptions.mobile, | |||
| routing: commandOptions.routing, | |||
| inlineStyle: commandOptions.inlineStyle, | |||
| inlineTemplate: commandOptions.inlineTemplate | |||
| inlineTemplate: commandOptions.inlineTemplate, | |||
| ignoredFiles: ['favicon.ico'] | |||
There was a problem hiding this comment.
Can you change this prop to be ignoredUpdateFiles?
|
Just a nit, definitely a useful feature. Thanks! |
Avoid crashes when choosing to diff the favicon.ico during overwrite. Closes angular#2274
filipesilva
approved these changes
Oct 10, 2016
JJayet
pushed a commit
to JJayet/angular-cli
that referenced
this pull request
Oct 14, 2016
Avoid crashes when choosing to diff the favicon.ico during overwrite. Closes angular#2274 Close angular#2617
texel
pushed a commit
to splice/angular-cli
that referenced
this pull request
Nov 3, 2016
Avoid crashes when choosing to diff the favicon.ico during overwrite. Closes angular#2274 Close angular#2617
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid crashes when choosing to diff the favicon.ico during overwrite.
Closes #2274
I'm assuming people either want to keep their favicon or the default one, but as the option to overwrite would be there anyway... who doesn't want to diff a favicon.ico? So I think to avoid the crashes is better to ignore it when updating the cli.