Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ng init crashes when using diff on favicon.ico #2274

Closed
celliott181 opened this issue Sep 21, 2016 · 1 comment
Closed

ng init crashes when using diff on favicon.ico #2274

celliott181 opened this issue Sep 21, 2016 · 1 comment
Labels
P5 The team acknowledges the request but does not plan to address it, it remains open for discussion

Comments

@celliott181
Copy link
Contributor

Please provide us with the following information:

  1. OS: Windows 10 x64
  2. Versions: Angular-CLI 1.0.0-beta.14, NodeJS 6.5.0
  3. Repro steps: Run ng init in an Angular-CLI project. At the prompt to (Yndh) the overwriting of favicon.ico enter d to produce a diff of the two files. The CLI will crash.
  4. The log given by the failure. Normally this include a stack trace and some
    more information.
    ? Overwrite src\favicon.ico? Diff
    value.split is not a function
    TypeError: value.split is not a function
    at Object.lineDiff.tokenize (../../src/diff/line.js:7:32)
    at Object.diff (../../src/diff/base.js:28:39)
    at diffLines (../../src/diff/line.js:31:71)
    at structuredPatch (../../src/patch/create.js:8:16)
    at createTwoFilesPatch (../../src/patch/create.js:98:16)
    at Object.createPatch (../../src/patch/create.js:122:10)
    at c:\cndctr\node_modules\angular-cli\lib\models\file-info.js:65:23
    at tryCatch (c:\cndctr\node_modules\rsvp\dist\lib\rsvp\-internal.js:215:12)
    at invokeCallback (c:\cndctr\node_modules\rsvp\dist\lib\rsvp\-internal.js:230:13)
    at publish (c:\cndctr\node_modules\rsvp\dist\lib\rsvp\-internal.js:198:7)
    at flush (c:\cndctr\node_modules\rsvp\dist\lib\rsvp\asap.js:82:5)
    at _combinedTickCallback (internal/process/next_tick.js:67:7)
    at process._tickCallback (internal/process/next_tick.js:98:9)
  5. Mention any other details that might be useful.
    Nothing extra, just a low priority bug that might pop up for some users. Current workaround is just to never diff the favicon.ico file.
@filipesilva filipesilva added type: enhancement P5 The team acknowledges the request but does not plan to address it, it remains open for discussion labels Oct 3, 2016
Puigcerber added a commit to Puigcerber/angular-cli that referenced this issue Oct 9, 2016
Avoid crashes when choosing to diff the favicon.ico during overwrite.

Closes angular#2274
Puigcerber added a commit to Puigcerber/angular-cli that referenced this issue Oct 10, 2016
Avoid crashes when choosing to diff the favicon.ico during overwrite.

Closes angular#2274
JJayet pushed a commit to JJayet/angular-cli that referenced this issue Oct 14, 2016
Avoid crashes when choosing to diff the favicon.ico during overwrite.

Closes angular#2274
Close angular#2617
Brocco pushed a commit that referenced this issue Oct 19, 2016
Avoid crashes when choosing to diff the favicon.ico during overwrite.

Closes #2274
Close #2617
texel pushed a commit to splice/angular-cli that referenced this issue Nov 3, 2016
Avoid crashes when choosing to diff the favicon.ico during overwrite.

Closes angular#2274
Close angular#2617
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
P5 The team acknowledges the request but does not plan to address it, it remains open for discussion
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants