fix(@angular/cli): change the url for doc search #16846
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alan-agius4
added
action: merge
|
Merged to patch branch 9.0.x as well. |
gkalpak
added a commit
to gkalpak/angular-cli
that referenced
this pull request
Feb 6, 2020
In angular#16846, the URL for docs search was updated to point to the corresponding vX.angular.io website (with an appropriate query for the search). However, on the archive versions of the website (i.e. versions older than the current stable), non-docs pages (including the home page) are redirected to `/docs` (losing the query params). This commit fixes the URL to include `/docs`, so that it is not redirected (and preserve the query params that will trigger the search).
gkalpak
reviewed
Feb 6, 2020
| } | ||
|
|
||
| let searchUrl = `https://${domain}/api?query=${options.keyword}`; | ||
|
|
||
| if (options.search) { | ||
| searchUrl = `https://www.google.com/search?q=site%3A${domain}+${options.keyword}`; | ||
| searchUrl = `https://${domain}/?search=${options.keyword}`; |
There was a problem hiding this comment.
I just realized that for archive version (i.e. older than the current stable), non-docs pages (including the home page) are redirected to /docs (losing the query params). So, this URL should be https://${domain}/docs?search=${options.keyword} 😅
(My bad for suggesting the wrong URL 😇)
I submitted #16856.
dgp1130
pushed a commit
that referenced
this pull request
Feb 7, 2020
In #16846, the URL for docs search was updated to point to the corresponding vX.angular.io website (with an appropriate query for the search). However, on the archive versions of the website (i.e. versions older than the current stable), non-docs pages (including the home page) are redirected to `/docs` (losing the query params). This commit fixes the URL to include `/docs`, so that it is not redirected (and preserve the query params that will trigger the search).
dgp1130
pushed a commit
that referenced
this pull request
Feb 7, 2020
In #16846, the URL for docs search was updated to point to the corresponding vX.angular.io website (with an appropriate query for the search). However, on the archive versions of the website (i.e. versions older than the current stable), non-docs pages (including the home page) are redirected to `/docs` (losing the query params). This commit fixes the URL to include `/docs`, so that it is not redirected (and preserve the query params that will trigger the search). (cherry picked from commit 1beb582)
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #16840