Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong request for ng doc -s #16840

Closed
OmarioHassan opened this issue Feb 4, 2020 · 11 comments · Fixed by #16846
Closed

Wrong request for ng doc -s #16840

OmarioHassan opened this issue Feb 4, 2020 · 11 comments · Fixed by #16846

Comments

@OmarioHassan
Copy link
Contributor

When i run ng doc component it works well but when i try to use -s for all searches option it gives wrong value

image

@santoshyadavdev
Copy link
Contributor

santoshyadavdev commented Feb 4, 2020

Hi @OmarioHasan,

Thanks for raising this, let me check. I was able to reproduce it as well. Also try to use standard template for raising issues. If you can update this issue would be better.

@santoshyadavdev
Copy link
Contributor

santoshyadavdev commented Feb 4, 2020

Hi @gkalpak, @kapunahelewong ,

After looking into the issue this is what i found

https://www.google.com/search?q=site%3Av8.angular.io+component (existing doesn't work)

https://www.google.com/search?q=site%3A%20v8.angular.io+component (added a space after site and this works)

I also referred to http://www.googleguide.com/advanced_operators_reference.html#site where it says we should not use space between site:domain. Can you guide me to official doc if possible.

@OmarioHassan
Copy link
Contributor Author

What standard templates it or where can i read about it
thanks in advance @santoshyadav198613

@santoshyadavdev
Copy link
Contributor

What standard templates it or where can i read about it
thanks in advance @santoshyadav198613

When you click on new issue and select bug you get an entire form, please try to fill as much info as possible.
https://github.com/angular/angular/issues/new?template=1-bug-report.md

@gkalpak
Copy link
Member

gkalpak commented Feb 4, 2020

AFAICT, having a space after site: just voids its effect (i.e. searches for the three terms: site, v8.angular.io and component). The reason the query does not show any results is that we do not allow the *.angular.io domains (such as v8.angular.io or next.angular.io) to be indexed by search engines (only angular.io).

We have to discuss this with the team and decide what is the most appropriate solution.
Thx for bringing it up, @OmarioHasan (and @santoshyadav198613 for doing the initial investigation) 👍

@gkalpak
Copy link
Member

gkalpak commented Feb 4, 2020

Some possible solutions off the top of my head (non-exhaustive list):

  • Change CLI to always use site:angular.io (regardless of the version).
    Cons: Might show info that does not correspond with the user's Angular version.

  • Change CLI to use https://v8.angular.io/?search=<some-term>
    Cons: Might show less matches than a Google search.

@clydin clydin transferred this issue from angular/angular Feb 4, 2020
@ngbot ngbot bot modified the milestone: Backlog Feb 4, 2020
@santoshyadavdev
Copy link
Contributor

Let me know @gkalpak i will take this once, we have final call on changes.

@gkalpak
Copy link
Member

gkalpak commented Feb 5, 2020

As discussed "offline", we will go with the second approach (changing to URL to https://v8.angular.io/?search=<some-term>). Given that the search will be for a single term, the results should be fine.

@santoshyadavdev
Copy link
Contributor

Cool @gkalpak I will make the changes.

@santoshyadavdev
Copy link
Contributor

Just an question here @gkalpak , it will be only for -s option right.

santoshyadavdev added a commit to santoshyadavdev/angular-cli that referenced this issue Feb 6, 2020
dgp1130 pushed a commit that referenced this issue Feb 6, 2020
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Mar 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants