build: use webpack for building apps. #1325
Conversation
|
We found a Contributor License Agreement for you (the sender of this pull request) and all commit authors, but as best as we can tell these commits were authored by someone else. If that's the case, please add them to this pull request and have them confirm that they're okay with these commits being contributed to Google. If we're mistaken and you did author these commits, just reply here to confirm. |
TheLarkInn
changed the title
|
@s-panferov s-panferov/awesome-typescript-loader#188 getting merged is very important for this build to pass. Let me know if you need to followup on it with me. |
| "declaration": false, | ||
| "emitDecoratorMetadata": true, | ||
| "experimentalDecorators": true, | ||
| "mapRoot": "/", | ||
| "module": "commonjs", | ||
| "module": "es6", |
|
@TheLarkInn Did you push the commit with VSCode or some other editor perhaps? Sometimes if you're in an office it could be strangely connected to some network drive that mysteriously has a .gitconfig on it, and it attached those names/emails on it. (Very bizarre I know). Wow so no more SystemJS? 👍 |
filipesilva
force-pushed
the
webpack
branch
3 times, most recently
from
1f1ca0c to
b9fb3ef
Compare
| @@ -0,0 +1,272 @@ | |||
|
|
|||
There was a problem hiding this comment.
Remove. Please use stashing and/or ghost commits to save work.
| "mapRoot": "/", | ||
| "module": "commonjs", | ||
| "module": "es6", | ||
| "target": "es5", |
There was a problem hiding this comment.
Keep this file alphabetically ordered please.
|
CLAs look good, thanks! |
hansl
changed the title
| chunksSortMode: 'dependency' | ||
| }), | ||
| new webpack.optimize.CommonsChunkPlugin({ | ||
| name: ['polyfills', 'vendor'].reverse() |
There was a problem hiding this comment.
This is something PatrickJS added on his starter, but you can simply put it on the right order, is just two items.
There was a problem hiding this comment.
Was this for tracking who was using it @filipesilva was curious. I thought it had bearing.
| @@ -10,6 +10,7 @@ | |||
| "keywords": [], | |||
There was a problem hiding this comment.
There seems to be a lot more stuff here that have been added, than what is actually needed.
|
We found a Contributor License Agreement for you (the sender of this pull request) and all commit authors, but as best as we can tell these commits were authored by someone else. If that's the case, please add them to this pull request and have them confirm that they're okay with these commits being contributed to Google. If we're mistaken and you did author these commits, just reply here to confirm. |
filipesilva
force-pushed
the
webpack
branch
2 times, most recently
from
40d9b4b to
b119b6d
Compare
|
@googlebot these commits have been authored in by @TheLarkInn, @filipesilva and @hansl. All three ok with them their commits being included in this PR. |
This pull request replaces the underlying broccoli build system and then replaces it with webpack as the build and bundler. This will affect the following commands (however the user-level) functionality should go unchanged (besides unimplemented flags which will come after this PR.): ng build (with --env flag and --watch flag supported) ng serve (with --port flag supported) ng test / ng e2e The webpack configuration is blackboxed, and therefore users will not see a webpack.config.js file in their repository. Also this PR will bump the typescript version to 2.0 (beta). Fixes #909 #1155 #882
…ode, indentation causing linting errors, add back tsconfig sourcemapping, removed console logs, deleted material unused files.
filipesilva
force-pushed
the
webpack
branch
2 times, most recently
from
1d1833e to
e64a527
Compare
|
Closing this for now, as we will work with PR to the webpack branch from now on. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This pull request replaces the underlying broccoli build system and then replaces it with
webpackas the build and bundler.This will affect the following commands (however the user-level) functionality should go unchanged (besides unimplemented flags which will come after this PR.):
ng build(with --env flag and --watch flag supported)ng serve(with --port flag supported)ng test / ng e2eThe webpack configuration is blackboxed, and therefore users will not see a
webpack.config.jsfile in their repository.Also this PR will bump the typescript version to 2.0 (beta).
Fixes #909 #1155 #882