Fix for #3123 (thanks to @anantanandgupta): use $templateRequest in templateFactory #3182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- modified `$templateFactory` to use `$templateRequest` provider of AngularJs in case it is avalable - removed the test case which enforces the setting of request header `Accept: text/html`
- AngularJS 1.0.8 don't have $injector.has
Replace 1.3.0 with 1.3.17.
…on 1.3+ templateFactory uses templateRequest, which calls the $sce to run the usual security checks on template URLs. This change verifies that the policy is indeed enforced, and that the user can provide $sce-trusted types through templateFactory (i.e., no assumptions are made that URLs are plain strings).
|
Oops, missed the gruntfile. Fixed. |
|
@rjamet Thanks for providing those tests. I guess that is no issue in that way of pull request as your commits are completely bases on my commits, if admins want to complete and pull my PR, they should be able to do it along with your commit. |
|
Looks good. Since this is a breaking change it will require a 0.4.0 release. Then users who do not want to keep using $http can call: .config($templateFactory => $templateFactory.useTemplateRequest(false));` Last but not least, this should be merged into master. |
This was referenced Dec 9, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on PR #3155 from @anantanandgupta, fixing #3123 with more tests on top of it.
I've also updated the 1.3.x Angular used for tests to the latest one, 1.3.0 had a few $sce-related bugs. I got the Angular files from Google's CDN.
Finally, I'm not entirely sure this is the right way to send these commits, as I'm not too used to github: I can't propose commits to his PR, right? I'd be happy to send this another way if this is not the appropriate workflow :/