use $templateRequest from AngularJS in ui-router 0.3.2 #3155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- modified `$templateFactory` to use `$templateRequest` provider of AngularJs in case it is avalable - removed the test case which enforces the setting of request header `Accept: text/html`
|
@christopherthielen i am not sure why that build is failing I have run all the supporting version from 1.2.x |
- AngularJS 1.0.8 don't have $injector.has
|
ok ... good to go ... it was failing in Angular 1.0.8 ... fixed and tests passed. |
- modified `$templateFactory` to use `$templateRequest` provider of AngularJs in case it is avalable - removed the test case which enforces the setting of request header `Accept: text/html`
- AngularJS 1.0.8 don't have $injector.has
|
Closing in favor of #3182 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
$templateFactoryto use$templateRequestprovider ofAngularJs in case it is avalable
Accept: text/html